Tickets/dm 15015 #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmwv
commented
Nov 9, 2018
| with pyplot.rc_context(dict(interactive=False)): | ||
| if isMask: | ||
| for i, p in reversed(list(enumerate(planeList))): | ||
| if colors[i + 1][3] == 0: |
There was a problem hiding this comment.
Explain for the reader of the code
- Why
i+1instead ofi? - That
[3]is the alpha channel. Perhaps as simple as
alpha_channel = 3
[...]
if colors[i + 1][alpha_channel] == 0
Could do these even higher up above so that the colors[i + 1][3] = alpha in line 320 used this same alpha_channel. It's more obvious in line 320 because of the variable name on the rhs, but for consistency could do both.
| extent=extent, cmap=cmap, norm=norm) | ||
| maskArr[:] = 0 | ||
|
|
||
| if self._fastMaskDisplay: # we only draw the lowest bitplane |
There was a problem hiding this comment.
This comment should say 'we only draw the lowest bitplane set for each pixel'.
maskArr[bitIsSet] = i + 1 accumulates for each item in planeList. The maskArr is only reset if not self._fastMaskDisplay.
| """ | ||
| Initialise a matplotlib display | ||
|
|
||
| @param fastMaskDisplay If True, only show the first bitplane that's set |
Useful as matplotlib's GREEN is very dark
Useful with e.g. %ipympl
I'm not sure how it ever worked. Calling `imshow` with an empty mask appears to erase all mask display (matplotlib bug?)
Should be added to afwDisplay's API
Also clarify the code a little post-review
RobertLuptonTheGood
force-pushed
the
tickets/DM-15015
branch
from
661f2e6 to
a3fc192
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.