DM-52725: Improve robustness when PhotoCalib yields non-finite zeropoint #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behavior of how warps with missing psf-matched warps are excluded in CompareWarp
yalsayyad
force-pushed
the
tickets/DM-52725
branch
from
c4b8787 to
7ed1645
Compare
yalsayyad
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AssembleCoadd now skips warps that are all 0/0/inf
makeDirectWarp now skips detectors that have non-finite photocalibs (the cause of the 0/0/inf warps)
Skipping behavior is unchanged, just in both cases the "if" was expanded a bit to include infs.