DM-12594: Remove daf::base::Citizen

src/CoaddBoundedField.cc

@@ -153,9 +153,7 @@ class CoaddBoundedFieldPersistenceKeys1 {
               throwOnMissing(schema.addField<afw::table::Flag>(
                       "throwOnMissing", "whether to throw an exception on missing data")),
               default_(schema.addField<double>("default",
-                                               "default value to use when throwOnMissing is False")) {
-        schema.getCitizen().markPersistent();
-    }
+                                               "default value to use when throwOnMissing is False")) {}
 };
 
 // Singleton class that manages the second persistence catalog's schema and keys
@@ -187,9 +185,7 @@ class CoaddBoundedFieldPersistenceKeys2 {
               wcs(schema.addField<int>("wcs", "archive ID of the Wcs associated with this element")),
               validPolygon(schema.addField<int>("validPolygon",
                                                 "archive ID of the Polygon associated with this element")),
-              weight(schema.addField<double>("weight", "weight value for this element")) {
-        schema.getCitizen().markPersistent();
-    }
+              weight(schema.addField<double>("weight", "weight value for this element")) {}
 };
 
 }  // namespace

src/CoaddPsf.cc

@@ -353,9 +353,7 @@ class CoaddPsfPersistenceHelper {
               averagePosition(afw::table::PointKey<double>::addFields(
                       schema, "avgpos", "PSF accessors default position", "pixel")),
               warpingKernelName(
-                      schema.addField<std::string>("warpingkernelname", "warping kernel name", 32)) {
-        schema.getCitizen().markPersistent();
-    }
+                      schema.addField<std::string>("warpingkernelname", "warping kernel name", 32)) {}
 };
 
 }  // namespace

src/CoaddTransmissionCurve.cc

@@ -196,10 +196,7 @@ struct CoaddTransmissionCurve::PersistenceHelper {
               bbox(afw::table::Box2DKey::addFields(inputDataSchema, "bbox", "bounding box of the sensor",
                                                    "pixel")),
               weight(inputDataSchema.addField<double>("weight",
-                                                      "relative weight for this sensor in the average")) {
-        mainSchema.getCitizen().markPersistent();
-        inputDataSchema.getCitizen().markPersistent();
-    }
+                                                      "relative weight for this sensor in the average")) {}
 };
 
 void CoaddTransmissionCurve::write(OutputArchiveHandle& handle) const {

src/DoubleGaussianPsf.cc

@@ -78,9 +78,7 @@ struct DoubleGaussianPsfPersistenceHelper {
                                                               "pixel")),
               sigma1(schema.addField<double>("sigma1", "radius of inner Gaussian", "pixel")),
               sigma2(schema.addField<double>("sigma2", "radius of outer Gaussian", "pixel")),
-              b(schema.addField<double>("b", "central amplitude of outer Gaussian (inner amplitude == 1)")) {
-        schema.getCitizen().markPersistent();
-    }
+              b(schema.addField<double>("b", "central amplitude of outer Gaussian (inner amplitude == 1)")) {}
 };
 
 class DoubleGaussianPsfFactory : public afw::table::io::PersistableFactory {

src/KernelPsf.cc

@@ -61,9 +61,7 @@ KernelPsfPersistenceHelper::KernelPsfPersistenceHelper()
         : schema(),
           kernel(schema.addField<int>("kernel", "archive ID of nested kernel object")),
           averagePosition(afw::table::PointKey<double>::addFields(
-                  schema, "averagePosition", "average position of stars used to make the PSF", "pixel")) {
-    schema.getCitizen().markPersistent();
-}
+                  schema, "averagePosition", "average position of stars used to make the PSF", "pixel")) {}
 
 bool KernelPsf::isPersistable() const noexcept { return _kernel->isPersistable(); }
 

src/SingleGaussianPsf.cc

@@ -81,9 +81,7 @@ struct SingleGaussianPsfPersistenceHelper {
             : schema(),
               dimensions(afw::table::PointKey<int>::addFields(schema, "dimensions",
                                                               "width/height of realization of Psf", "pixel")),
-              sigma(schema.addField<double>("sigma", "radius of Gaussian", "pixel")) {
-        schema.getCitizen().markPersistent();
-    }
+              sigma(schema.addField<double>("sigma", "radius of Gaussian", "pixel")) {}
 };
 
 class SingleGaussianPsfFactory : public afw::table::io::PersistableFactory {