Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-32337: Add straight image stacking to AccumulatorMeanStack. #263

Merged
merged 1 commit into from Oct 26, 2021

Conversation

erykoff
Copy link
Contributor

@erykoff erykoff commented Oct 25, 2021

No description provided.

Copy link
Member

@arunkannawadi arunkannawadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

----------
image : `lsst.afw.image.Image`
Image to add to the stack.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weight is not documented

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@@ -97,6 +97,8 @@ def add_masked_image(self, masked_image, weight=1.0):
----------
masked_image : `lsst.afw.image.MaskedImage`
Masked image to add to the stack.
weight : `float`, optional
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be an array of the same size as the image as well, right? Or is that use case not acceptable?

@erykoff erykoff merged commit 0aba325 into master Oct 26, 2021
@erykoff erykoff deleted the tickets/DM-32337 branch October 26, 2021 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants