DM-16724-v24: Dynamic detection failure due to lack of sky-object measurements is too quiet #324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, add an initial bright object detection pass with significant growing of footprints to account for wings. The negative polarity detections in this pass help in masking highly over-subtracted regions. In the next "preliminary" detection pass, the negative polarity threshold is increased (relative to the positive threshold) in order to avoid aggressive negative detections that leads to severe overmasking of the image (leaving no room for sky object placement). This also adds the INTRP and SAT mask planes to the list to avoid in sky object placement. A few config options are added related to the above and the minNumSources config is changed to be a minimum fraction of the total sky sources requested. The test is updated to reflect this rebranded config.
This raises NoWorkFound so that downstream tasks don't fail.
laurenam
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.