DM-40186-v26: Update dynamic detection task defaults and logging #352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the number of input visits increases, the number of pixels with the INTRP mask bit set increases, which eventually leads to a very large fraction pixels with this mask bit set. Thus, if INTRP is included in the list of masks to avoid when laying down sky objects, very deep coadds will end up with little-to-no available locations for sky objects, leading to a failure in the dynamic detection. Thus, the safest thing to do is leave it out of the masks to avoid list.
In the dynamic detection task, compute and log the number of "good" pixels in the exposure, where "good" is defined simply as not having either the NO_DATA or BAD mask bit set. If this fraction is greater than 20% of the total number of pixels, yet we still fail to locate enough spots to lay down sky objects, raise an RuntimeError exception. The message includes the fraction of the "good" pixels marked either DETECTED or DETECTED_NEGATIVE as this is a likely reason for this situation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.