DM-50118: Improve fits with non-flat backgrounds #443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmsaunders
force-pushed
the
tickets/DM-50118
branch
from
0b4586b to
2fe0177
Compare
yalsayyad
approved these changes
Oct 8, 2025
| bins=lineBins) | ||
| countAlongStreak, *_ = scipy.stats.binned_statistic(distanceFromLineEnd, maskDetections, | ||
| statistic='count', bins=lineBins) | ||
| detectionFraction = detectionsAlongStreak / countAlongStreak |
There was a problem hiding this comment.
Having just squashed a divide by zero runtime error yesterday I thought was impossible... think if truly impossible
There was a problem hiding this comment.
I don't think this can give a runtime error, because these are arrays, so dividing by zero gives a RuntimeWarning, not an error.
| lineModel = LineProfile(data, weights, line=line, detectionMask=detectionMask) | ||
| # Skip any lines that do not cover any data (sometimes happens because of chip gaps) | ||
| if lineModel.lineMaskSize == 0: | ||
| if lineModel.lineMask.size == 0: |
There was a problem hiding this comment.
Double check that you didn't mean if lineModel.lineMask.sum() == 0: here. lineMask.size isn't the same thing.
There was a problem hiding this comment.
Yeah, it took me a while to figure out what it should be because I did this part a while ago, but it should be lineMask.sum() == 0. Good catch!
cmsaunders
force-pushed
the
tickets/DM-50118
branch
from
2fe0177 to
77f9640
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.