DM-18855: Fix Python TypeError inheritance to match C++ #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inherit from LogicError not RuntimeError. Some things can become confused if pex.exceptions.TypeError inherits from builtins.TypeError and builtins.RuntimeError.
Without this change modern clang warns. The reason in this case
as that there is a mismatch between the item being returned
and the declared return type of the function.
In file included from tests/testLib.cc:30:
include/lsst/pex/exceptions/python/Exception.h:98:12: warning: local variable 'cls' will be copied despite being returned by name [-Wreturn-std-move]
return cls;
^~~
tests/testLib.cc:58:24: note: in instantiation of function template specialization 'lsst::pex::exceptions::python::declareException<TestError, lsst::pex::exceptions::Exception>' requested here
auto cls = python::declareException<TestError>(mod, "TestError", "RuntimeError");
^
include/lsst/pex/exceptions/python/Exception.h:98:12: note: call 'std::move' explicitly to avoid copying
return cls;
^~~
std::move(cls)
1 warning generated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lsst.pex.exceptions.TypeErrorno longer inherits fromRuntimeError.