DM-43939: Drop / prefix from doc URLs in the FastAPI app template #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before we had a bug where the OpenAPI docs wouldn't be available because their URL paths needed a double slash prefix "//" with the default configuration for path_prefix. The path_prefix in Config includes a "/" prefix by default, and app.include_router is set up to use the config's "/" prefix, and so I think the correct behaviour is for the config to have the path prefix.
jonathansick
added a commit
to lsst-sqre/fastapi-bootcamp
that referenced
this pull request
Apr 17, 2024
I think this was a bug in our template that'll be fixed in lsst/templates#253
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we had a bug where the OpenAPI docs wouldn't be available because their URL paths needed a double slash prefix "//" with the default configuration for path_prefix.
The path_prefix in Config includes a "/" prefix by default, and app.include_router is set up to use the config's "/" prefix, and so I think the correct behaviour is for the config to have the path prefix.