-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving test coverage, doi badge, fix read_fhx blank space bug #162
Conversation
Hey @chguiterman! Thanks for the code! Are you ready for a review on this PR? Could you walk me through your "A minor fix to read_fhx() for flexibility"... How did you come across this? What happens, exactly? |
Hey @brews |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes generally look good. Really happy to see coverage improve, @chguiterman! Thanks so much for this PR.
Given the time crunch I'm fine to merge this but I created new issues to
- update NEWS.md (Update NEWS.md #163)
- add a unit test for the FHX file whitespace problem (Add read_fhx() unit test for whitespace at end of file #164)
These need to be taken care of before our next release.
Also includes:
read_fhx()
for flexibility