Update unit test for write_fhx() #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(1)`reshape2` is "retired" withthe recomendation to transition to `tidyr`. Updated dcast to pivot_wider, added @importFrom to function documentation, which passes to the NAMESPACE and required Imports in DESCRIPTION. (2) 'Standard' FHX2 files include a space between the data block and year. `write_fhx()` did not include that space. This did not cause problems for `read_fhx()` or any other outside program, but it made it difficult to error check the output of `write_fhx()`. `list_filestrongs()` now adds the space. My checks on the created FHX files all look fine. * test-io.R: Now checks for equal creation of an FHX file. And the years output from `list_filestrings()` is updated to the character vector.
brews
requested changes
Jul 7, 2020
There was a problem hiding this comment.
This looks great! Thanks so much for the update, @chguiterman.
One requested change before merging:
- Could you add a new bullet point in NEWS mentioning the new packages we depend on? If we require people to install new packages, I'd like that explicitly listed.
Thanks again! This is good stuff!
|
Good idea @brews -- got it. |
brews
approved these changes
Jul 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of PR#162.
I found that the FHX files created by
write_fhx()are slightly different from "standard" FHX2 files. The difference is a space between the data block and years column. I added this space to the output fromlist_filestrings()because that function is only called bywrite_fhx(). The year vector now includes a space, which more correctly formats the output FHX files.This addition facilitated an
expect_equal()unit test forwrite_fhx()that was previously being skipped.The newly formatted FHX file looked OK and read in fine with
read_fhx().Close #163.
Close #164.