Skip to content

Conversation

Megaf
Copy link
Contributor

@Megaf Megaf commented Mar 7, 2018

Making all channels match code style and text formatting.
Adding a more direct and clear description to each channel.
Making use of uppercase for aesthetics and to make things more relevant.
Adding webchat for Minetest-Hub. In the topic of the channel we have a link for the channels website and it also says about voice and asking an op for it.
Adding webchat for Minetest-Hub. Mainly to match style.

Opinions needed.

Making all channels match code style and text formatting.
Adding a more direct and clear description to each channel.
Making use of uppercase for aesthetics and to make things more relevant.
Adding webchat for Minetest-Hub. In the topic of the channel we have a link for the channels website and it also says about voice and asking an op for it.
Adding webchat for Minetest-Hub. Mainly to match style.

Opinions needed.
irc.html Outdated
See <a href="http://hub.minetest.net/info">the channel's website</a> for more information.
<strong><a href="https://webchat.freenode.net/?channels=#minetest-hub">#Minetest-Hub</a></strong>
(<a href="http://irc.minetest.net/minetest-hub">Logs</a>):
Community channel, to talk about modding, server adminitration and short off-topic.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The channel is not for offtopic; it's simply something we usually accept. I prefer the previous description for -hub, then adjust the other two so they are full sentences.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And what about the description for the other channels?

@Ezhh
Copy link

Ezhh commented Mar 7, 2018

@Megaf You are pretty close already. #minetest needs a better description than we started with. Maybe instead of:
Main channel, where players can join to chat and get support about Minetest.
try:
Main channel where all players and contributors can discuss the game or request support.
(This is more inclusive, so I think it would be better.)

And for -dev, I'd suggest not replacing the current information (unless you can maybe think of a better term than "serious stuff"), but do fix the capitalisation ("development channel" to "Development channel") so it matches the others.

Megaf added 2 commits March 7, 2018 21:55
Reverting Minetest-Hub description.
Improvements on Minetest description.
TODO on -Dev, we have to rephrase serious stuff.
Updated Minetest-Dev description.
@Megaf Megaf changed the title [WIP] Channel description improvements 2. Channel description improvements 2. Mar 7, 2018
@sofar
Copy link
Contributor

sofar commented Mar 8, 2018

lgtm

irc.html Outdated
</strong>
(<a href="http://irc.minetest.net/minetest-dev">logs</a>):
development channel, only serious stuff; note that webchat is muted due to too much spam/flood.
<strong><a href="https://webchat.freenode.net/?channels=#minetest-dev">#Mminetest-Dev</a></strong>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

irc.html Outdated
(<a href="http://irc.minetest.net/minetest">logs</a>): main channel
<strong><a href="https://webchat.freenode.net/?channels=#minetest">#Minetest</a></strong>
(<a href="http://irc.minetest.net/minetest">Logs</a>):
Main channel where all players and contributors can discuss the game or request support.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why explicitly name which group of people this channel for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was something we came with when discussing about it on #-dev. Do you have other suggestions?

irc.html Outdated
development channel, only serious stuff; note that webchat is muted due to too much spam/flood.
<strong><a href="https://webchat.freenode.net/?channels=#minetest-dev">#Mminetest-Dev</a></strong>
(<a href="http://irc.minetest.net/minetest-dev">Logs</a>):
"Development channel, strictly engine or minetest_game development talk only; note that webchat is muted due to too much spam/flood."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quotes not needed

Copy link
Contributor Author

@Megaf Megaf Mar 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

irc.html Outdated
(<a href="http://irc.minetest.net/minetest-hub">logs</a>):
A moderated channel for people who regularly improve Minetest by developing, modding, hosting servers and otherwise.
See <a href="http://hub.minetest.net/info">the channel's website</a> for more information.
<strong><a href="https://webchat.freenode.net/?channels=#minetest-hub">#Minetest-Hub</a></strong>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is the channel name capitalized?
this does not reflect their actual names on IRC

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because Minetest is capitalised and on IRC is up to the IRC client and/or user to "decide" how to represent it. Besides, in my opinion it looks better and more serious when capitalised.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's lower case on the official page: http://hub.minetest.net/info
So it needs to be lower case here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only lowercase makes sense, that is specifically the channel name.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in case it matters: the IRC specification does not mention channel names being case-insensitive, so #minetest and #Minetest might in theory be totally different channels

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Roger.

irc.html Outdated
(<a href="http://irc.minetest.net/minetest">logs</a>): main channel
<strong><a href="https://webchat.freenode.net/?channels=#minetest">#Minetest</a></strong>
(<a href="http://irc.minetest.net/minetest">Logs</a>):
Main channel where everyone is welcome to discuss the game or request support.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this description any better?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might change it to "Main channel for general game and engine discussion or support" in the next commit tho.

Copy link
Contributor

@paramat paramat Mar 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember MT is not a 'game', better to refer to 'Minetest engine' and 'games' (plural) as other games can be discussed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that 'everyone is welcome' is not needed.

irc.html Outdated
development channel, only serious stuff; note that webchat is muted due to too much spam/flood.
<strong><a href="https://webchat.freenode.net/?channels=#minetest-dev">#Minetest-Dev</a></strong>
(<a href="http://irc.minetest.net/minetest-dev">Logs</a>):
Development channel, strictly engine or minetest_game development talk only; note that webchat is muted due to too much spam/flood.
Copy link
Contributor

@paramat paramat Mar 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line too long in code, can it be split? I assume it auto-wraps when displayed on the webpage.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A web browser will indeed auto-wrap, so I wouldn't worry much about long line.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, long line is best avoided in the code, if possible.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paramat Better? And at least least nothing changed visually on Safari, just the editing in a console window gets easier with the line break indeed.

irc.html Outdated
See <a href="http://hub.minetest.net/info">the channel's website</a> for more information.
<strong><a href="https://webchat.freenode.net/?channels=#minetest-hub">#Minetest-Hub</a></strong>
(<a href="http://irc.minetest.net/minetest-hub">Logs</a>):
A moderated channel for people who regularly improve Minetest by developing, modding, hosting servers and otherwise.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above, if possible split long line in code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above.

Megaf added 2 commits March 9, 2018 23:45
Decapitalised channel names.
Change in #minetest description.
I broke the line so they we can see the whole line in a standard terminal window using a text editor like nano or vi.
@sfan5 sfan5 dismissed a stale review March 10, 2018 12:09

.

@Megaf
Copy link
Contributor Author

Megaf commented Mar 10, 2018

So, what about we keep the link to web chats and add a note like so.
screen shot 2018-03-10 at 12 28 51

<div>
  <p>
    Join one of our <abbr title="Internet Relay Chat">IRC</abbr> channels on Freenode:<br/>
    Please note that in order to chat on #minetest-hub you need to
    ask an operator for voice and to chat on #minetest-dev you 
    need to be using a real IRC client.<br>
  </p>
  <ul>
    <li>
      <strong><a href="https://webchat.freenode.net/?channels=#minetest">#minetest</a></strong>
        (<a href="http://irc.minetest.net/minetest">Logs</a>):
        Main channel for general Minetest engine and games discussion or
        support.
    </li>
    
    <li>
      <strong><a href="https://webchat.freenode.net/?channels=#minetest-dev">#minetest-dev</a></strong>
        (<a href="http://irc.minetest.net/minetest-dev">Logs</a>):
        Development channel, strictly engine or minetest_game development
        talk only.
    </li>
    
    <li>
      <strong><a href="https://webchat.freenode.net/?channels=#minetest-hub">#minetest-hub</a></strong>
        (<a href="http://irc.minetest.net/minetest-hub">Logs</a>):
        A moderated channel for people who regularly improve Minetest
        by developing, modding, hosting servers and otherwise.
    </li>
  </ul>
</div>

Added a short notice about how to chat on -hub and -dev before the list of channels.
Keeping web chat links
irc.html Outdated
development channel, only serious stuff; note that webchat is muted due to too much spam/flood.
<strong><a href="https://webchat.freenode.net/?channels=#minetest-dev">#minetest-dev</a></strong>
(<a href="http://irc.minetest.net/minetest-dev">Logs</a>):
Development channel, strictly engine or minetest_game development
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe 'Minetest engine' here for consistency with the above?

Copy link
Contributor

@rubenwardy rubenwardy Mar 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or

strictly for discussions of <a href="https://github.com/minetest">official projects'</a> development

irc.html Outdated
<p>
Join one of our <abbr title="Internet Relay Chat">IRC</abbr> channels on Freenode:<br/>
Please note that in order to chat on #minetest-hub you need to
ask an operator for voice and to chat on #minetest-dev you
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Long sentence, perhaps:
ask an operator for voice, to chat on #minetest-dev you
?

@paramat
Copy link
Contributor

paramat commented Mar 12, 2018

Fine apart from my line comments.

irc.html Outdated
Join one of our <abbr title="Internet Relay Chat">IRC</abbr> channels on Freenode:<br/>
Please note that in order to chat on #minetest-hub you need to
ask an operator for voice and to chat on #minetest-dev you
need to be using a real IRC client.<br>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of saying "you need a real irc client" just say that you "can't use webchat on -dev"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  <p>
    Join one of our <abbr title="Internet Relay Chat">IRC</abbr> channels on Freenode:<br/>
    To chat on #minetest-hub you need to ask an operator for voice. You can't you the webchat on #minetest-dev.<br>
  </p>

Good?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/can't you/can't use/
yes

irc.html Outdated
<div>
<p>
Join one of our <abbr title="Internet Relay Chat">IRC</abbr> channels on Freenode:<br/>
To chat on #minetest-hub you need to ask an operator for voice. You can't use the webchat on #minetest-dev.<br>
Copy link
Contributor

@paramat paramat Mar 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't use webchat on #minetest-dev
No need for 'the'

irc.html Outdated
<strong><a href="https://webchat.freenode.net/?channels=#minetest">#minetest</a></strong>
(<a href="http://irc.minetest.net/minetest">logs</a>): main channel
(<a href="http://irc.minetest.net/minetest">Logs</a>):
Main channel for general Minetest engine and games discussion or
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost suggests modding can't be discussed here.
Main channel for general Minetest engine, modding and games discussion or support.

irc.html Outdated
<strong><a href="https://webchat.freenode.net/?channels=#minetest-dev">#minetest-dev</a></strong>
(<a href="http://irc.minetest.net/minetest-dev">Logs</a>):
Development channel, strictly for discussions of <a href="https://github.com/minetest">official projects'</a> development.
talk only.
Copy link
Contributor

@paramat paramat Mar 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes no sense.
strictly only for discussions of <a href="https://github.com/minetest">official projects'</a> development.

irc.html Outdated
development channel, only serious stuff; note that webchat is muted due to too much spam/flood.
<strong><a href="https://webchat.freenode.net/?channels=#minetest-dev">#minetest-dev</a></strong>
(<a href="http://irc.minetest.net/minetest-dev">Logs</a>):
Development channel, strictly only for discussions of <a href="https://github.com/minetest">official projects'</a> development.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm actually, linking to the homepage and calling that 'official projects' isn't descriptive, the home page doesn't have an 'official projects' section and what is official isn't obvious.
How about no link and describing what can be discussed (MTEngine, MTGame), as before?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the old description again? Will see if I can find it easily

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

`..., strictly only for development discussion of the Minetest engine and Minetest Game'
'discussion' doesn't need to be plural.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, what about one of the description that we came with before.

Development channel, for topics related to bug reporting and general Minetest development.

@Megaf
Copy link
Contributor Author

Megaf commented Mar 12, 2018

I think I have addressed everything by now.
Anything else?

irc.html Outdated
<div>
<p>
Join one of our <abbr title="Internet Relay Chat">IRC</abbr> channels on Freenode:<br/>
To chat on #minetest-hub you need to ask an operator for voice. You can't use webchat on #minetest-dev.<br>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small thing, i think this sounds better, as a native English speaker:
Webchat cannot be used on #minetest-dev.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All else is fine for me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, I agree.

@Megaf
Copy link
Contributor Author

Megaf commented Mar 12, 2018

Done.

@paramat
Copy link
Contributor

paramat commented Mar 12, 2018

👍 Text is ok for me.

@Ezhh
Copy link

Ezhh commented Mar 13, 2018

Fine by me 👍

@rubenwardy rubenwardy merged commit 79a98b5 into luanti-org:master Mar 13, 2018
@Megaf Megaf deleted the patch-1 branch March 13, 2018 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants