Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds sorting functionality #21

Merged
merged 3 commits into from
Jun 24, 2019
Merged

Adds sorting functionality #21

merged 3 commits into from
Jun 24, 2019

Conversation

miread
Copy link
Contributor

@miread miread commented Jun 20, 2019

Fixes some issues that were requested in #15

Partially implements #6
Closes #15

README.md Outdated Show resolved Hide resolved
@lubien lubien mentioned this pull request Jun 20, 2019
4 tasks
@miread
Copy link
Contributor Author

miread commented Jun 24, 2019

Please approve my pull request, and I'll get to work on the next task.

@lubien
Copy link
Owner

lubien commented Jun 24, 2019

Hi @miread I've made a review asking for just one fix on your code can you check it out?

@miread
Copy link
Contributor Author

miread commented Jun 24, 2019

I did take a look at your request. The problem is that you say the indentation is off - this is a mistake. The formatting on github is showing an incorrect preview that looks like the indentation is bad. However, if you click on the README.md file and view the entire contents, you will see that the indentation is all even. I have double- and triple-checked this.

@lubien
Copy link
Owner

lubien commented Jun 24, 2019

Actually the reason is that you used spaces for indentation while I've used tabs, GitHub caught that.

I've used 3 tabs. You used 24 spaces.

It might result in inconsistencies. I know this is nitpick, do you mind changing it?

@miread
Copy link
Contributor Author

miread commented Jun 24, 2019

If spacing consistency is that important to you, then you shouldn't be putting tabs into your code. This issue is your problem, not mine.

@lubien
Copy link
Owner

lubien commented Jun 24, 2019

If you don't want to do this much it's fine, I'll accept the PR then do it myself.

I must say I dislike how you're handling things here blaming design choices of the repo. Please refrain from further contributions.

The code so far you've made is appreciated though. Wish you the best in the future.

@lubien lubien merged commit 24bf322 into lubien:master Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants