Exit Worker process on Fatal exceptions #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jroylance
approved these changes
Sep 14, 2020
JaredNeil
force-pushed
the
jaredneil-catch-fatal
branch
from
8112693 to
66a469d
Compare
JaredNeil
changed the title
The default global ExecutionContext simply logs uncaught exceptions. Since Future only catches NonFatal exceptions, any Fatal exceptions would cause the Future to never complete, which meant a WorkResponse was never sent back to the bazel server, which would then be stuck waiting forever for a response. Since Fatal exceptions can leave the JVM in an invalid state, we exit if any thread has an unhandled Fatal exception.
Zinc seems to run into this error pretty frequently, and if uncaught, the entire worker process will exit suddenly, which can leave Bazel in a weird state where it tries to send messages to the worker, but can't because the process has already exited. Consider this a temporary workaround until the underlying issues with Bazel can be fixed.
JaredNeil
force-pushed
the
jaredneil-catch-fatal
branch
from
66a469d to
fef122d
Compare
jroylance
approved these changes
Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default global ExecutionContext simply logs uncaught exceptions. Since Future only catches NonFatal exceptions, any Fatal exceptions would cause the Future to never complete, which meant a WorkResponse was never sent back to the bazel server, which would then be stuck waiting forever for a response.
Since Fatal exceptions can leave the JVM in an invalid state, we exit if any thread has an unhandled Fatal exception.