Add non-zero exit code when deps check fails #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidANeil
force-pushed
the
davidneil-non-zero-exit-code
branch
from
6d40126 to
234fc6c
Compare
jnowjack-lucidchart
approved these changes
Mar 31, 2025
DavidANeil
force-pushed
the
davidneil-non-zero-exit-code
branch
from
234fc6c to
11f30e4
Compare
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids a Buildfarm issue where it gives unhelpful error messages (that don't include stderr) when outputs are missing after a 0 exit code.
It also gives a better error message generally, as you don't get the superfluous messages:
I have not tested this, nor do I plan on testing this.