Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link edit/delete buttons show up on officer page when not logged in #1085

Closed
sea-kelp opened this issue Jan 5, 2024 · 0 comments · Fixed by #1086
Closed

Link edit/delete buttons show up on officer page when not logged in #1085

sea-kelp opened this issue Jan 5, 2024 · 0 comments · Fixed by #1086
Assignees

Comments

@sea-kelp
Copy link
Collaborator

sea-kelp commented Jan 5, 2024

What issue are you seeing?

Currently, the link edit and delete buttons show up on the officer page when visiting as an anonymous user.

This is NOT a security issue as the user is asked to log in after clicking the link but may be confusing to users.

michplunkett pushed a commit that referenced this issue Jan 5, 2024
## Fixes issue
Fixes #1085

## Description of Changes
This is a cherry-pick of
OrcaCollective#403

---

Currently, the link edit and delete buttons show up on the officer page
when visiting as an anonymous user. (see:
https://openoversight.com/officers/83835)

This is NOT a security issue as the user is asked to log in after
clicking the link but may be confusing to users.

## Notes for Deployment
None!

## Screenshots (if appropriate)
N/A

## Tests and linting
 - [x] This branch is up-to-date with the `develop` branch.
 - [x] `pytest` passes on my local development environment.
 - [x] `pre-commit` passes on my local development environment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant