Add updatePercent(percent) method. #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move requestAnimationFrame polyfill in order to make it usable everywhere in the plugin + create new method updatePercent(percent)
|
Haven't tried your patch yet but I'm definitely excited about this getting added. Much needed feature 👍 |
Because of self._interval, we can't make this polyfill global
Previous fix thrown an "Illegal invocation error"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we want to update the percent value of the circle, we need to create a whole new instance and animation of the circle restarts from 0.
This method allows us to update this value at any moment.
It does not take into account the "duration" option, it's an improvement we could make later if needed :)
(could be a fix for issue #9 )