Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal refactor on config commands of cli. #188

Merged
merged 2 commits into from
May 18, 2017
Merged

Internal refactor on config commands of cli. #188

merged 2 commits into from
May 18, 2017

Conversation

drgarcia1986
Copy link
Contributor

@drgarcia1986 drgarcia1986 commented May 16, 2017 •
edited by arnaldopereira
Loading

  • Remove duplicated code
  • Remove unnecessary code
  • Simplify

This change is Reviewable

aguerra
aguerra approved these changes May 16, 2017
View reviewed changes
Copy link
Contributor

@aguerra aguerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drgarcia1986 drgarcia1986 merged commit caf8f85 into master May 18, 2017
@drgarcia1986 drgarcia1986 deleted the dg-cli_config branch May 18, 2017 14:08
@drgarcia1986 drgarcia1986 mentioned this pull request Jun 2, 2017
Closed
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aguerra aguerra aguerra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drgarcia1986 @aguerra