Implement grpc create user #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use real storage.User struct.
cmd/client/cmd/user.go
Outdated
| @@ -99,12 +88,45 @@ func deleteUser(cmd *cobra.Command, args []string) { | |||
| fmt.Println("User deleted") | |||
| } | |||
|
|
|||
| func createUser(cmd *cobra.Command, args []string) { | |||
| name, _ := cmd.Flags().GetString("name") | |||
There was a problem hiding this comment.
Are we just ignoring errors on all input parsing?
There was a problem hiding this comment.
copy pasta from previous PR's, I will take a look into it
There was a problem hiding this comment.
I wouldn't do it now.
We can check for unexpected input errors in another PR.
pkg/server/user/user.go
Outdated
| if err := dbu.DB.Save(u).Error; err != nil { | ||
| return err | ||
| } | ||
| return nil |
There was a problem hiding this comment.
what about:
- if err := dbu.DB.Save(u).Error; err != nil {
- return err
- }
- return nil
+ return dbu.DB.Save(u).Error?
aguerra
force-pushed
the
ag-create-user-grpc
branch
from
e8eae1c
to
3eb1d9a
Compare
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is