Implement gRPC Team Add-User #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmd/client/cmd/team.go
Outdated
| @@ -140,3 +124,27 @@ func createTeam(cmd *cobra.Command, args []string) { | |||
| } | |||
| fmt.Println("Team created with success") | |||
| } | |||
|
|
|||
| func teamAddUser(cmd *cobra.Command, args []string) { | |||
| team, _ := cmd.Flags().GetString("team") | |||
There was a problem hiding this comment.
Shouldn't we test for errors here?
aguerra
approved these changes
May 18, 2017
pkg/server/team/handlers_test.go
Outdated
| return | ||
| } | ||
| } | ||
| t.Errorf("AddUser dont add user for a team") |
There was a problem hiding this comment.
Maybe AddUser didn't add user in team
cmd/client/cmd/team.go
Outdated
| conn, err := connection.New(cfgFile) | ||
| if err != nil { | ||
| fmt.Fprintln(os.Stderr, "Erro connecting to server:", err) | ||
| return |
drgarcia1986
force-pushed
the
dg-team_add_user-grpc
branch
from
7397076
to
dcea361
Compare
…e implementation
drgarcia1986
force-pushed
the
dg-team_add_user-grpc
branch
from
dcea361
to
8e0d8c5
Compare
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is