[Proposal] Standardize errors and Logs with Middlewares #214
Conversation
drgarcia1986
force-pushed
the
dg-error_handle
branch
from
1fe06f5
to
815b684
Compare
pkg/server/k8s/client.go
Outdated
| if _, err := k.kc.CoreV1().Services(namespace).Create(srvSpec); err != nil { | ||
| return errors.Wrap(err, "create service failed") | ||
| } | ||
| return nil | ||
| } |
There was a problem hiding this comment.
I guess you can write:
_, err := k.kc.CoreV1().Services(namespace).Create(srvSpec)
return errors.Wrap(err, "create service failed")There was a problem hiding this comment.
Does errors.Wraps returns nil for non errors (i.e. nil) args ?
pkg/server/deploy/handlers.go
Outdated
| @@ -54,7 +55,7 @@ func (s *Service) Make(stream dpb.Deploy_MakeServer) error { | |||
| rs := bytes.NewReader(content.Bytes()) | |||
| rc, err := s.ops.Deploy(u, appName, rs, description, s.options.RevisionHistoryLimit) | |||
| if err != nil { | |||
| return err | |||
| return teresa_errors.Get(err) | |||
There was a problem hiding this comment.
I thought you could return err here because the log middleware does the unwrapping, am I right?
pkg/server/middlewares.go
Outdated
| return teresa_errors.Get(err) | ||
| } | ||
| return nil | ||
| } |
There was a problem hiding this comment.
Also, I added the user of the request. Check some examples below and let know if you liked.
time="2017-07-18T14:32:31Z" level=error msg="Log Interceptor got an Error" error="namespaces \"hashpass2\" already exists" request=name:"hashpass2" team:"arquitetura" limits:<default:<quantity:"500m" resource:"cpu" > default:<quantity:"512Mi" resource:"memory" > default_request:<quantity:"200m" resource:"cpu" > default_request:<quantity:"512Mi" resource:"memory" > > auto_scale:<cpu_target_utilization:70 max:2 min:1 > route="/app.App/Create" user="diego.garcia@luizalabs.com"
time="2017-07-18T14:33:17Z" level=error msg="Log Interceptor got an Error" error="rpc error: code = NotFound desc = App not found: get annotation failed: namespaces \"hashpass3\" not found" route="/deploy.Deploy/Make" user="diego.garcia@luizalabs.com"
ps: In the unary interceptor, I'm logging request content.
drgarcia1986
force-pushed
the
dg-error_handle
branch
from
b9c6b84
to
ac5e728
Compare
Only applied for
Deploypkg.This change is