[LUM-473] Add ability to catch errors on websocket implementation #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: [LUM-638] Add pagination to millions extension (#56) [LUM-619] Add Millions messages (#55) Hotfix (#54) [LUM-548] Upgrade dependencies and add Amino types (#53) Bump version Register new upgrade module messages Register legacy options (#52) Upgrade SDK JS to match chain latest used version (#51)
Segfaultd
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Currently, when we create the SDK websocket listener we cannot specify an 'on error' event. Which means in the case of a connection hangup or failure, the listener will stay in an zombie state.
Solution:
Add try / catch with onError event in client
connectfunction