Add support for Linux and macOS #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dean0x7d
force-pushed
the
python-for-all
branch
2 times, most recently
from
1becc7e to
e7ef994
Compare
bkarpati
reviewed
May 31, 2021
There was a problem hiding this comment.
Typo in the second commit message
download a pre-build binary -> download a pre-built binary
Also, would it be possible to stick with the standard line length limit for the lines containing the caveats as well?
Otherwise I don't have much else to add. Great to have the cross-platform support in place.
Of course! I copy/pasted from the changelog and forgot to apply the line limit. Fixed now. |
sjlamerton
approved these changes
Jun 3, 2021
This is an MVP implementation of Linux and macOS support. Everything is functional but there are two caveats that should certainly be resolved in future versions: * The standard library is not pre-compiled and zipped so it takes up more space than the Windows variant. * The environment is not as locked down as the Windows variant: `pip` is still accessible in the final package. On Windows, we can simply download a pre-built binary embedded package, but on macOS and Linux, we need to build from source and lock down the environment ourselves. This means that the two points above require a bit more effort. We can tackle this later. For now, this implementation is certainly good enough to get going.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an MVP implementation of Linux and macOS support. Everything is functional but there are two caveats that should certainly be resolved in future versions:
pipis still accessible in the final package.On Windows, we can simply download a pre-build binary embedded package, but on macOS and Linux, we need to build from source and lock down the environment ourselves. This means that the two points above require a bit more effort. We can tackle this later. For now, this implementation is certainly good enough to get going.