RD-3150 - faster http hooks #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self.method = kwargs["method"] | ||
| self.uri = kwargs["uri"] | ||
| self.headers = kwargs.get("headers") | ||
| self.headers = {k.lower(): v for k, v in (kwargs.get("headers") or {}).items()} |
There was a problem hiding this comment.
lowering everything once (instead of the underline __getter__ function) ~6s
| def should_scrub_domain(url: str) -> bool: | ||
| if url and Configuration.domains_scrubber: | ||
| for regex in Configuration.domains_scrubber: | ||
| if re.match(regex, url, re.IGNORECASE): |
There was a problem hiding this comment.
compile regexes once (~3s)
| headers, body = data.split(_BODY_HEADER_SPLITTER, 1) | ||
| if _FLAGS_HEADER_SPLITTER in headers: | ||
| hooked_headers = getattr(instance, LUMIGO_HEADERS_HOOK_KEY, None) | ||
| if hooked_headers: |
There was a problem hiding this comment.
instead of parse the headers from the bytes - use the hook (~20s)
| else: | ||
| Configuration.domains_scrubber = DOMAIN_SCRUBBER_REGEXES | ||
| domains_scrubber_regex = DOMAIN_SCRUBBER_REGEXES | ||
| Configuration.domains_scrubber = [re.compile(r, re.IGNORECASE) for r in domains_scrubber_regex] |
There was a problem hiding this comment.
compile only on configuration
doriaviram
approved these changes
Jul 7, 2020
| "region": region, | ||
| "parentId": request_id, | ||
| "info": {"tracer": {"version": version}, "traceId": {"Root": trace_root}}, | ||
| "event": event, |
There was a problem hiding this comment.
send the event and envs only on functions spans
Codecov Report
@@ Coverage Diff @@
## master #120 +/- ##
==========================================
+ Coverage 96.21% 96.28% +0.06%
==========================================
Files 11 11
Lines 952 996 +44
==========================================
+ Hits 916 959 +43
- Misses 36 37 +1
Continue to review full report at Codecov.
|
saartochner-lumigo
pushed a commit
that referenced
this pull request
Jul 7, 2020
a73472c layers-table: layers md [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
banchmark: lambda with 256MB memory, doing 10,000 ddb get_item requests, with xray that close a segment every 1000 requests.
Without lumigo: 241s
With old lumigo: 320s
with new lumigo: 292s
I.e. total of 35.5% less overhead