RD-3763 - sqlalchemy #159
Merged
RD-3763 - sqlalchemy #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into RD-3761-wrap-pymongo
…into RD-3761-wrap-pymongo
…acer into RD-3761-wrap-pymongo
…acer into RD-3690-redis-sqlalchemy-elasticsearch
…to RD-3763-sqlalchemy
nirLumigo
suggested changes
Oct 20, 2020
Comment on lines
+68
to
+71
| with lumigo_safe_execute("sqlalchemy: listen to engine"): | ||
| listen(result, "before_cursor_execute", _before_cursor_execute) | ||
| listen(result, "after_cursor_execute", _after_cursor_execute) | ||
| listen(result, "handle_error", _handle_error) |
There was a problem hiding this comment.
I think you forgot to commit this change 😅
There was a problem hiding this comment.
I did! checkout line 80
nirLumigo
approved these changes
Oct 20, 2020
Codecov Report
@@ Coverage Diff @@
## master #159 +/- ##
==========================================
+ Coverage 96.21% 97.99% +1.77%
==========================================
Files 11 22 +11
Lines 952 1597 +645
==========================================
+ Hits 916 1565 +649
+ Misses 36 32 -4 Continue to review full report at Codecov.
|
saartochner-lumigo
pushed a commit
that referenced
this pull request
Oct 25, 2020
98e7170 layers-table: layers md [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.