Skip to content

Conversation

saartochner-lumigo
Copy link
Contributor

@saartochner-lumigo saartochner-lumigo commented Jan 10, 2021

If someone initializes an AWS connection during the cold start phase, then we will create a spans_container, thus marking this container as “hot”.
I changed the behavior to mark it as “hot” only when creating a span_container due to invocation start.

@codecov
Copy link

codecov bot commented Jan 10, 2021

Codecov Report

Merging #177 (5e1d7c3) into master (827a7a9) will increase coverage by 1.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #177      +/-   ##
==========================================
+ Coverage   96.21%   97.45%   +1.23%     
==========================================
  Files          11       22      +11     
  Lines         952     1767     +815     
==========================================
+ Hits          916     1722     +806     
- Misses         36       45       +9     
Impacted Files Coverage Δ
lumigo_tracer/parsers/utils.py
lumigo_tracer/sync_http/handler.py
lumigo_tracer/utils.py
lumigo_tracer/parsers/parser.py
lumigo_tracer/sync_http/sync_hook.py
lumigo_tracer/parsers/http_data_classes.py
lumigo_tracer/parsers/event_parser.py
lumigo_tracer/wrappers/http/http_data_classes.py 100.00% <0.00%> (ø)
lumigo_tracer/lumigo_utils.py 95.30% <0.00%> (ø)
lumigo_tracer/auto_instrument_handler.py 100.00% <0.00%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 826c688...5e1d7c3. Read the comment docs.

@saartochner-lumigo saartochner-lumigo merged commit 6d411c8 into master Jan 10, 2021
@saartochner-lumigo saartochner-lumigo deleted the RD-4424-cold-start-indication branch January 10, 2021 14:49
saartochner-lumigo pushed a commit that referenced this pull request Jan 10, 2021
…n pre-invocation calls (#177)

826c688 layers-table: layers md [skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants