feat: add nested-auto-execution-tags #241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirLumigo
reviewed
Feb 22, 2022
| if key in event: | ||
| add_execution_tag(key, event[key]) | ||
| try: | ||
| value = safe_get(event, key.split(".")) # type: ignore |
There was a problem hiding this comment.
The user won't be able to auto-tag keys that have "." in them. Are we ok with this?
We can use json format instead which is a bit more complicated but will allow using ".".
There was a problem hiding this comment.
yes!
we can support escaping, but this is future work IMO.
WDYT?
nirLumigo
approved these changes
Feb 22, 2022
Codecov Report
@@ Coverage Diff @@
## master #241 +/- ##
==========================================
+ Coverage 96.21% 96.81% +0.59%
==========================================
Files 11 24 +13
Lines 952 2073 +1121
==========================================
+ Hits 916 2007 +1091
- Misses 36 66 +30
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.