add support for python 3 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 23, 2019 13:36
joycelau1
reviewed
Aug 23, 2019
| @@ -1,3 +1,6 @@ | |||
| # 0.2.1 | |||
| * Add Python 3 support | |||
There was a problem hiding this comment.
are we adding python 3 support or replacing 2 with 3? New code won't work with Python 2, right?
There was a problem hiding this comment.
it will work with both py2 and py3
joycelau1
reviewed
Aug 23, 2019
|
|
||
| class EPTRNParser(Parser): | ||
| def __init__(self, config_file=os.path.join(os.path.dirname(os.path.realpath(__file__)), 'config/eptrn.yml')): | ||
| super(self.__class__, self).__init__() | ||
|
|
||
| self.eptrn_config = load(open(config_file))['DETAIL_RECORD'] | ||
| self.section_types = [v for k, v in self.eptrn_config['TYPE_MAPPING'].iteritems()] | ||
| self.section_types = [v for k, v in iteritems(self.eptrn_config['TYPE_MAPPING'])] |
There was a problem hiding this comment.
this errors in python 2
>>> iteritems({})
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
NameError: name 'iteritems' is not defined
joycelau1
approved these changes
Aug 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some basic changes for supporting relative imports in Python 3, removed leading zero which is not supported in Python 3, added support for dict.iteritems