Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move package.json out of server to project root directory #94

Merged
merged 1 commit into from
Feb 27, 2017

Conversation

nadongguri
Copy link
Collaborator

we should consider to move the package.json to out of server directory.

@romandev romandev self-requested a review February 27, 2017 15:49
@romandev romandev assigned romandev and nadongguri and unassigned romandev Feb 27, 2017
Copy link
Member

@romandev romandev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@romandev romandev merged commit ac6b56a into lunchclass:master Feb 27, 2017
gogag2 added a commit that referenced this pull request Mar 7, 2017
And Chrome and SamsungBrowser don't need to run deeplink.

BUG=#94
gogag2 added a commit that referenced this pull request Mar 9, 2017
not using chrome and samsungbrowser.

BUG = #94
gogag2 added a commit that referenced this pull request Mar 9, 2017
And Chrome and SamsungBrowser don't need to run deeplink.

BUG = #94
gogag2 added a commit that referenced this pull request Mar 10, 2017
* Deeplink should be sent when users are using andorid phone.
We blocked sending deeplink when users are using the others phones.

BUG=#96

* Deeplink should open default browser without chooser activity.
And Chrome and SamsungBrowser don't need to run deeplink.

BUG=#94

* Deeplink should open default browser without chooser activity.
And Chrome and SamsungBrowser don't need to run deeplink.

BUG = #94
romandev pushed a commit that referenced this pull request Sep 30, 2017
We should consider to move the package.json to out of server directory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants