little improvements and bugs fixing #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 28 commits
July 27, 2017 11:10
``__init__`` input_file/output_file overload to support file object file descriptor filename template ``__init__`` make tempfile avoid race ``__del__``, ``__exit__`` avoid double closing and pre-delete to avoid race ``__output_gen`` uses seek to avoid reopen
add module ``log`` to control logging
add ``cyaron.graders.mismatch`` Mismatch HashMismatch TextMismatch modify ``cyaron.graders.fulltext`` & ``cyaron.graders.noipstyle`` to return Mismatch class instead of str error message
use log in ``cyaron.compare``, prints error to stderr add arguments to ``__compare_two`` raise_on_incorrect raise an error when incorrect dump_on_incorrect dump data on incorrect (default: True) ``stop_on_incorrect`` exit with code 1 instead of 0 to mark error state use TypeError instead of Exception when arguments missing to fit the behavior of python's
|
Currently no more changes needed. You could feel free to merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pending not merge
this pr includes some little improvements and bugs fixing
see commit messages for details