[pull] master from chromium:master #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
This reverts commit 9017200. Reason for revert: causes compile failure https://ci.chromium.org/ui/p/chromium/builders/ci/android-archive-rel/22335/overview Original change's description: > appcache: remove appcache inspector agent > > AppCache is disabled by default and is being removed. > > This is a reland of: > https://chromium-review.googlesource.com/c/chromium/src/+/3192227 > > This was reverted automatically here, for compile failures: > https://chromium-review.googlesource.com/c/chromium/src/+/3194167 > > Bug: 582750, 1084190 > Change-Id: I59cd4c6f43efe71a3ffea53270de1d0fd2a630d6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198850 > Auto-Submit: enne <enne@chromium.org> > Commit-Queue: Andrey Kosyakov <caseq@chromium.org> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Cr-Commit-Position: refs/heads/main@{#927064} Bug: 582750, 1084190 Change-Id: I9c55710b51bbbf05fe21b283c15a2baee7d36366 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198064 Auto-Submit: Fergal Daly <fergal@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Fergal Daly <fergal@google.com> Owners-Override: Fergal Daly <fergal@google.com> Cr-Commit-Position: refs/heads/main@{#927094}
IncognitoProfileContainmentTest now blocks adding new empty files in Incognito mode. Bug: 1234755 Change-Id: Ic48aae8494a0d09f638a548f98a796557e67a006 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3193998 Reviewed-by: Rohit Agarwal <roagarwal@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/main@{#927095}
ComponentCloudPolicyTest.UpdateExtensionPolicy UserPolicySigninServiceSyncNotRequiredTest.AcceptManagementDeclineSync DeviceManagementServiceIntegrationTest.PolicyFetch Bug: 1254962 Change-Id: Ic84d28b09a2a0c0563970c8ca0d57308fc3e50a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198095 Owners-Override: Fergal Daly <fergal@google.com> Reviewed-by: Takashi Sakamoto <tasak@google.com> Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/main@{#927096}
Doc: https://docs.google.com/document/d/1h2aSTCJJ815ORzEPzkr7CJIWiQYnBYUOn_lQqDInPJ0 Modify AppUpdate, to merge the change for apps::mojom::InstallSource, and add the interfaces to get InstallSource and InstallSourceChanged in AppUpdate. BUG=1250971 Change-Id: Ib067f8b025c0d9bb8128a50302bc2f2b67a63df6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3193488 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/main@{#927097}
…avigation Bug: 1177102 Change-Id: I731de8cbb28a841b67a206b18327f66a574517d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199190 Reviewed-by: Michael Crouse <mcrouse@chromium.org> Reviewed-by: Robert Ogden <robertogden@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/main@{#927098}
Reduce notification width by 10 to make room for scrollbar. Bug: 199360111 Test: manual Change-Id: I8a6f3e430748d1f220d8b90367bea0f2923ac58e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3159851 Auto-Submit: Sara Kato <sarakato@chromium.org> Commit-Queue: Sara Kato <sarakato@chromium.org> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/main@{#927099}
https://android.googlesource.com/platform/external/perfetto.git/+log/827c7cda1d72..c10e58491f2a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ib74f9023adbad68b7d851579df9f6e0711836155 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199450 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927100}
https://dawn.googlesource.com/dawn.git/+log/75911ca2b53c..5ad5250a3b38 2021-10-01 yunchao.he@intel.com Track read-only depth/stencil attachment as read-only usage 2021-10-01 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from ee23c1734546 to c57642cbd5ed (2 revisions) 2021-09-30 enga@chromium.org Grant flex-(ci/try)-led-users permission to trigger tasks If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I0f8b36a20d83d1b8b31fa75f13c7c14980273289 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199355 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927101}
Fixed: 1254909 Change-Id: Icf673ba256c431a6ec1a7a405b8e27f1cf026357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199034 Auto-Submit: Nate Chapin <japhet@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/main@{#927102}
https://chromium.googlesource.com/angle/angle.git/+log/1fdedbd45a55..3de06bcd0c81 2021-10-01 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 788a2f62acbe to 11c6360dd46f (144 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: Ibbfc9c1a73ecac80f520279e59957cefed574d29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199357 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927103}
Fix crashes by allowing PDF blob navigations to be intercepted, changing the assumption that no requests to blob navigations need intercepting. Within the PDF loading dance, the browser throttles PDF stream URL navigations and redirects them using the original PDF content URL. The new navigation gets intercepted and its loader is replaced with a page with an in-process plugin. When the original PDF content URL has a blob: scheme, the interceptor was skipped, thus invoking another PDF extension embedded inside the first one. The consequent nested WebContents then led to weird behavior, causing crashes. Add tests that load PDF blob URLs to avoid future regressions. Credit to alexmos@ and kmoon@ for playing critical roles in debugging the issue. Fixed: 1253314 Change-Id: Ieb0071bac6ffc61ad69a419ace4469a1a576bafa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3194567 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by: K. Moon <kmoon@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/main@{#927104}
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/aec1ec3abcbd..cf0cb984c0bf 2021-10-01 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0ea262516a2801fe7ae194dfee449e6dba7b5af3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199360 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927105}
The protocol accepts rounded corners in the following order - top left, top right, bottom right, bottom left. The same order of parameters is accepted by gfx::RoundedCornersF. This CL fixes the incorrect order of parameters. Bug: b/192238059 Change-Id: Iad7eae28c6b24333e389d4ebd6c2570ac348b60c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3196173 Reviewed-by: Mitsuru Oshima (exo only) <oshima@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/main@{#927106}
Currently, ViewAccessibility::NotifyAccessibilityEvent gets called by some view components. See earlier patchsets. This method was put into place with the assumption that ViewAccessibility has a subclass that would handle the real dispatch. This is true for some platforms e.g. with AXPlatformNodeDelegate(s), but it isn't true on Chrome OS. It also misses the call to View::OnAccessibilityEvent within View::NotifyAccessibilityEvent which a views View can override. Fix by making this method private/renaming to *Internal and only allowing the call from View::NotifyAccessibilityEvent. Change-Id: I50493f5d77fe8ed3ba422681f263a0ca703fae7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198376 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/main@{#927107}
https://skia.googlesource.com/skia.git/+log/7bb0ff05cec5..b011afc82fde 2021-10-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 4d2bc396ea3b to 5ad5250a3b38 (17 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: csmartdalton@google.com Change-Id: I89c579880aeb1abb12910415d5c5d95286f7b86b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199452 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927108}
This patch changes |ShouldInsertSpaceBetweenObjectsIfNeeded()| to handle block-in-inline[1][2], e.g. <div>abc<p aria-hidden>XYZ</p>def</div> should be "abc def" instead of "abcdef" by |AXNodeObject:: TextFromDescendants()|. [1] accessibility/name-calc-aria-hidden.html [2] http/tests/inspector-protocol/accessibility/accessibility-nameSources-visiblity.js Bug: 716930 Change-Id: I2c3a59544c5ed68639ddc492937f81d3cd2a8cbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3185560 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/main@{#927109}
Several key histograms for Related Searches and Touch to Search are expired in M95, and we need to move them to M99 to ensure we have data for experiments that are still running. Almost all of these are either Related Searches or Contextual Search Settings change histograms. Both are in active experimentation for M95 and having a few milestones of headroom seems prudent given the shorter release cycle. BUG=1244883,1244884,1244885,1244697,1242552,1224545 Change-Id: I99140e65ce1771e98d628f028b7d1c4964d5e3b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3197834 Auto-Submit: Donn Denman <donnd@chromium.org> Commit-Queue: Weilun Shi <sweilun@chromium.org> Reviewed-by: Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/main@{#927110}
Roll Chrome Win64 PGO profile from chrome-win64-main-1633046263-aec5318bad29ff97aac3e64c920a6f0da28233bb.profdata to chrome-win64-main-1633056962-0d21bf1851dc5fecc5809e64d117b5b6f2ea9cb9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I06e47d146473acbf785e9ec83b45483c287f2473 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199362 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927111}
This allows finer-grained control over the RenderFrameHostImpl state exposed to destructors of various extensions points (such as DocumentServiceBase and RenderDocumentHostUserData) when the RenderFrameHostImpl is also being destroyed. Bug: 1252046, 1253869 Change-Id: I637bac38a7532b4539fbe7f3a93c2166a4627e55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3195388 Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/main@{#927112}
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2675bf77a225..89e3cfec57cc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC fergal@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: fergal@google.com Change-Id: I3af6d7a3fe21b65f54e42d185bdf3f2d9a8e8118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199590 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927113}
This reverts commit cf8dd57. Reason for revert: causing SavePageBrowserTest.SaveDownloadableIFrame to fail on msan Original change's description: > Add ClientSideDetectionDocumentScanning field trial details > > Adding ClientSideDetectionDocumentScanning field trial details to start > experiment on Beta. This feature will enable the scanning of Office > documents (e.g., pptx, docx, etc.) to detect the presence of macros. > > Bug: 1188201 > Change-Id: Iecda9928bdf2c24ef46f67ac585585ab7b967b8b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3182720 > Commit-Queue: Olabode O. Anise II <anise@chromium.org> > Reviewed-by: Daniel Rubery <drubery@chromium.org> > Cr-Commit-Position: refs/heads/main@{#926489} Bug: 1188201,1254730 Change-Id: Ia1af34c911eda72c95256df114fd5034a87ba662 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3197853 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Fergal Daly <fergal@google.com> Owners-Override: Fergal Daly <fergal@google.com> Cr-Commit-Position: refs/heads/main@{#927114}
This CL restricts the value of `window.parent` specifically in fenced
frames implemented on top of ShadowDOM. This is one of several API-level
restrictions to create the look and feel of fenced frames [1].
This CL also adds the following tests:
- Top-level fenced frame:
A test ensuring that for a top-level fenced frame, `window.parent`
returns the fenced frame's window, not the outermost window.
- Nested iframe:
A test ensuring that for an iframe inside a fenced frame,
`window.parent` returns the fenced frame's window, not the
<iframe>'s window nor the "outermost" window.
- Nested fenced frame:
A test ensuring that for a nested fenced frame, `window.parent`
returns the most local fenced frame's `window`
[1]: https://docs.google.com/document/d/1ijTZJT3DHQ1ljp4QQe4E4XCCRaYAxmInNzN1SzeJM8s/edit#heading=h.jztjmd6vstll
R=dcheng@chromium.org, shivanisha@chromium.org
Bug: 1123606
Change-Id: I7357a7e16bf5e855f4cff28dbfdcd6175478dadc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3191870
Commit-Queue: Dominic Farolino <dom@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#927115}
https://skia.googlesource.com/skia.git/+log/b011afc82fde..4ec483e95238 2021-10-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 8d1e74abd5d6 to 3de06bcd0c81 (11 revisions) 2021-10-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from cde65f7a8816 to b7b7cb76042a (1 revision) 2021-10-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 3ccf954 to 3bc0154 (513 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: csmartdalton@google.com Change-Id: I460d1f0201993a9669e0d8f6775076a92423ef03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199593 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927116}
Before this, CORP was not enforced for resource loading from WebBundles because it's checked by network::URLLoader for regular network request but WebBundles does not use network::URLLoader. This enforces CORP header for subresource requests from WebBundles, by calling CrossOriginResourcePolicy::IsBlocked() from WebBundleURLLoaderFactory. Bug: 1163788 Change-Id: I42b720b9bfa55e57cba04181ddff848f2aa952a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3160605 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Tsuyoshi Horo <horo@chromium.org> Reviewed-by: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/main@{#927117}
This patch adds fuzzy-match to: wpt_internal/css/css-ui/outline-block-in-inline.html When LayoutNGBlockInInline is enabled, it has anti-aliasing differences in rounded corners of outlines. Example failure: https://test-results.appspot.com/data/layout_results/linux-rel/813378/blink_web_tests%20%28with%20patch%29/layout-test-results/results.html Also increased `line-height` to avoid overlapping outlines. LayoutNGBlockInInline will unite overlapping outlines that it will not match the ref file if overlapping occurs. Bug: 716930 Change-Id: Ide72df117d7487a19c05c0c26a974902b2011d92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3197854 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Koji Ishii <kojii@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/main@{#927118}
Roll Chrome Win32 PGO profile from chrome-win32-main-1633024553-0228268c46b992b4a28dfec6c78a9cc353fad1fa.profdata to chrome-win32-main-1633056962-ac096d230ae8fe18e57abc42c02212d17d31a2d1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I341b64e81e5c661fff73d7f7d34a2168b2c781a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199366 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927119}
https://chromium.googlesource.com/catapult.git/+log/01df326efe16..c0b9d253fbf9 2021-10-01 rbpotter@chromium.org testForegroundTab test: Close extra tab if necessary for consistency If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1254233 Tbr: nuskos@google.com Change-Id: I47884c41c82e842aae7a506236d4b62d2ac66193 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199454 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927120}
This CL updates the ash version 94.0.4606.69 for Lacros version skew testing. If this CL caused regressions, please revert and stop the autoroller at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller Also please file a bug to OS>LaCrOS>Partner, and CC svenzheng@chromium.org, liaoyuke@chromium.org, yjt@google.com. R=rubber-stamper@appspot.gserviceaccount.com Bug: None Change-Id: Ida3cb368c21de58843ba6e5196cdfde369571bfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199572 Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927121}
Change-Id: I55bf69c14122c92052b4b5d3af707fab721f7cc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3193935 Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Asami Doi <asamidoi@chromium.org> Reviewed-by: Ben Kelly <wanderview@chromium.org> Reviewed-by: Brian White <bcwhite@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/main@{#927122}
Browser Settings uses prefs_mixin.js instead. CrOS Settings can't leverage Mixins yet, as it is using the legacy Polymer syntax. Bug: 1234307 Change-Id: I4aca1c5bafc62fe83bde6199eed657c052b2543c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3195090 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/main@{#927123}
Now that we have the host, we should assert the state is consistent. The RenderFrameHost should only load if the storage key matches, so I don't think new tests are needed (especially since we already essentially cover this case using the security policy). The prior attempt at this change (https://crrev.com/c/3122751). Took a quick and dirty approach which required a revert. This code is on a critical path, has a lot of quick fixes layered, and is under-tested. Let's take a slower approach as follows: (1) Refactor session and local storage checks (2) Add StorageKey to IPC (3) Add LocalFrameToken to IPC and verify Bug: 1212808 Change-Id: Icd3698555d313cb65525ccb441abe0704b21137b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3176309 Auto-Submit: Ari Chivukula <arichiv@chromium.org> Commit-Queue: Ari Chivukula <arichiv@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/main@{#927198}
Roll Chrome Linux PGO profile from chrome-linux-main-1633067199-d1ccff023a1b4744cd74cfb3cfd24e1382ed48b1.profdata to chrome-linux-main-1633089497-be838448aa9157f7ffb673521b457f3b4d4a96f5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib9105402f7982012d5a6ea5660b882d9fb74a6bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199725 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927199}
Use the existing (and common) IsA<> and DynamicTo<> rather than open-coding and using 'raw' casts. Change-Id: I6d05722c776a91ad07a06f14e2d6107c3538f6d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198072 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/main@{#927200}
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/9889b057fc2e..a3f2d160917b 2021-10-01 jacktfranklin@chromium.org Expose RenderCoordinator pending frames count If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4b4ec84bfadd39fe92f68d6a6340f38c3ff08b11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199720 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927201}
Although the behavior described in crbug.com/1069935 was unable to be reproduced, there were previously no unit tests to verify that domain cookies set by IP addresses were refused by CanonicalCookie::IsCanonical(). Additional test cases were also added for domain attributes with localhost values, as they were previously uncovered. R=bingler Bug: 1069935 Change-Id: I55809712c5da379bb59f95d2565e2caeb546b9d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3197637 Commit-Queue: Joshua Hood <jdh@chromium.org> Auto-Submit: Joshua Hood <jdh@chromium.org> Reviewed-by: Steven Bingler <bingler@chromium.org> Cr-Commit-Position: refs/heads/main@{#927202}
Roll Chrome Win64 PGO profile from chrome-win64-main-1633078660-d5e8e783b95df01e297d64f96f4af9fa3bd65d73.profdata to chrome-win64-main-1633089497-e8cfd19b9c37dcfc995323a07984860afb9e9271.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I2a08405060ca98131f9f9864d54feacf28f1e6bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199723 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927203}
Add util function which creates a PolicyBundle using the provided scope, source, and vector of policy names and values. This function is used to refactor various unit tests and decrease the amount of repeated code. Bug: N/A Change-Id: Iaa824ca5afb832d2105c8c75fe1f50b8c223dc73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3158174 Reviewed-by: Owen Min <zmin@chromium.org> Commit-Queue: Igor Ruvinov <igorruvinov@chromium.org> Cr-Commit-Position: refs/heads/main@{#927204}
Roll Chrome Win32 PGO profile from chrome-win32-main-1633078660-2348f4907e50466f84f87de74916fc1e4afccb4b.profdata to chrome-win32-main-1633089497-4be84ee872c58c90115cdb68aa80d15b279481e9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ia7ba95811c095e3334e65916fde1416a8b005c4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199724 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927205}
Bug: 1227693 Change-Id: If1d8f13342dada51bb2c79d6f6a722344502c347 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3193994 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/main@{#927206}
This is part of a series of CLs to move the remaining top-level files from chrome/browser/chromeos/ to chrome/browser/ash/. This CL moves the ones containing ChromeOS in its name and renames it Ash. This CL is part of the Chrome OS source code directory migration: https://docs.google.com/document/d/1g-98HpzA8XcoGBWUv1gQNr4rbnD5yfvbtYZyPDDbkaE. Bug: 1164001 Change-Id: I34ca71f4e37f63916a538ef70d6f35aa00f56d4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3195975 Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Owners-Override: Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/main@{#927207}
…s for single_shot""" This reverts commit 3dd3bb6. Reason for revert: This is an intent-to-ship feature at https://groups.google.com/a/chromium.org/g/blink-dev/c/HKPTp7C1LwY that had done the new origin trial on M95 beta and we have to revert it until we have profitable result on the evaluation of the impact on M95 Beta. Original change's description: > Reland "Reland "Reland: Not clamp up setTimeout(..., 0) to 1ms for single_shot"" > > This is a reland of cd7dfaa, the chromium-dev@ > has agreed to reland this CL to do origin trial on Chrome Beta again. > See https://groups.google.com/a/chromium.org/g/blink-dev/c/HKPTp7C1LwY/m/5Rl78YJfAwAJ > > Original change's description: > > Reland "Reland: Not clamp up setTimeout(..., 0) to 1ms for single_shot" > > > > This is a reland of 390b973 > > > > Original change's description: > > > Reland: Not clamp up setTimeout(..., 0) to 1ms for single_shot > > > > > > The original CL has been reverted because some other tests failed > > > in multiple builders. This reland CL fixed these additional failure > > > tests. > > > > > > Consider the potential risk to web developers, this got approved > > > from intent-to-ship > > > https://groups.google.com/a/chromium.org/g/blink-dev/c/HKPTp7C1LwY > > > to flag this on for Beta(M91) for one release, and then based on test > > > result on beta to evaluate the impact. > > > > > > Original change's description: > > > > setTimeout(..., 0) is clamping up to 1ms for historical reasons: > > > > crbug.com/402694, and the issue has been open for years which was > > > > blocked by the challenge of updating all test expectations accordingly. > > > > > > > > Chrome doesn't need the clamp for anything in particular and no 1ms > > > > clamp in the spec, moreover, we found Speedometer2 performance can boost > > > > ~1% on Windows without it based on Pinpoint perf. > > > > > > > > Most failure tests failed with this change had been fixed in separated > > > > CLs. > > > > > > > > Bug: 402694 > > > > Change-Id: I46196584b887513ca520221be68099116931d4f2 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578703 > > > > Reviewed-by: Philip Jägenstedt <foolip@chromium.org> > > > > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > > > > Commit-Queue: Wanming Lin <wanming.lin@intel.com> > > > > Cr-Commit-Position: refs/heads/master@{#844459} > > > > > > Bug: 402694 > > > Change-Id: Ib27dc87d39e292f19c2dc6e9b918efbac2a5f1ee > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636507 > > > Commit-Queue: Wanming Lin <wanming.lin@intel.com> > > > Reviewed-by: Philip Jägenstedt <foolip@chromium.org> > > > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#858820} > > > > NOTE TO SHERRIFS: > > If any tests are flaky, please help to change setTimeout(..., 0) > > to setTimeout(..., 1) if it can be found in a test that regressed > > before reverting this CL. Otherwise please disable the test and > > assign the bug to me, I'll dig more. > > > > Bug: 402694 > > Change-Id: Ib75550d1ddd3544085b62d1d52b524e89330f99e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2730350 > > Commit-Queue: Wanming Lin <wanming.lin@intel.com> > > Reviewed-by: Philip Jägenstedt <foolip@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#865025} > > Bug: 402694 > Change-Id: I730effc0b4f2a3c8cfb89522297b472df421b468 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3115849 > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Wanming Lin <wanming.lin@intel.com> > Cr-Commit-Position: refs/heads/main@{#915448} Bug: 402694 Change-Id: I8faa9f52aa40fb256bbaa661e44808fc6f5502d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3195233 Commit-Queue: Wanming Lin <wanming.lin@intel.com> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/main@{#927208}
Bug: Dragging a link from an incognito page to the tab strip opens the page in the regular (non-incognito) profile. Fix: Explicitly set the incognito state in the URL opening params used to open the page. Test: Manual testing, integration test to follow. Bug: 1252777 Change-Id: If985355a6132fbdcc9775ce66979d6ca24a87bcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3197721 Commit-Queue: Mark Cogan <marq@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Mark Cogan <marq@chromium.org> Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/main@{#927209}
Change-Id: Ide7a792267f1307f65c695a2b28655b6fbb3eda0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199494 Auto-Submit: Ben Mason <benmason@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927210}
This CL is for adding a wpt to check if we assign correct interaction ids when we click. Bug: 1236758 Change-Id: I0c6fad3ef9301fc54868f4aee01507e7142d14e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3197873 Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/main@{#927211}
This CL refactors the code that sets the ChromeAppListItem instance's name. In detail, this CL does the following things: (1) Make ChromeAppListItem::SetName() and ChromeAppListItem::SetName- AndShortName() both protected member functions so that these two functions can be called only by ChromeAppListItem and its subclasses. The external classes should use ChromeAppListModelUpdater to set the item name (or short name). (2) Avoid calling the model updater in ChromeAppListItem::SetName() or ChromeAppListItem::SetNameAndShortName(). (3) Change FakeAppListModelUpdater::OnItemAdded() so that it becomes more similar to ChromeAppListModelUpdater::OnItemAdded(). Actually I tried to erase FakeAppListModelUpdater::OnItemAdded() but it is not easy. This CL should not bring any noticeable change to product users. Bug: 1252021 Change-Id: Ia7fb03d539d833486d03abca3e79150c55542ac0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198297 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/main@{#927212}
Same as when this was previously done for other platforms (in crrev.com/c/2429243), leave the fieldtrial testing config stuff as-is because it is testing the still-manipulated-via-feature-param "DisabledProviders" list. Bug: 1127671 Change-Id: I3182e300085e9e11ab177c54ccff92730f199abb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198710 Auto-Submit: Eric Orth <ericorth@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/main@{#927213}
Trusted Types protects against XSS by providing a configurable boundary
for HTML insertion into the DOM. execCommand with the "insertHTML" command
works around these. This introduces Trusted Types check for
execCommand("insertHTML") that are the exact equivalent of element.innerHTML.
Tests ensure that - if TT is not enabled - execCommand will work as before.
Tests also ensure that - if TT is enabled - execCommand with "insertHTML"
will obey TT policies and the default policy, while other sub-commands will
continue to work as before.
Bug: 1230567
Change-Id: Iaa50b01bec4061f53b6d66b0b21f63527f2b71a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3048161
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org>
Cr-Commit-Position: refs/heads/main@{#927214}
This fixes a test crash if you try to run a test that creates a FastInitiationScanner after running the FastInitiationScannerFeatureUsageMetricsTest suite. Bug: 1223888 Change-Id: Ia20eb866c3353018ef12cd3196648c647a0cbf0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199050 Auto-Submit: Michael Hansen <hansenmichael@google.com> Reviewed-by: Josh Nohle <nohle@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/main@{#927215}
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/1d79c892cf25..68fae526c447 2021-10-01 apodtele@gmail.com * src/autofit/afhints.c (af_glyph_hints_reload): Decrease casting. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC thestig@google.com,bungeman@google.com,drott@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10.20h2-blink-rel;luci.chromium.try:win7-blink-rel Tbr: thestig@google.com,bungeman@google.com,drott@google.com Change-Id: I28dce6f36e5188066f21e90db5b37621b97bcaa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199074 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Ben Wagner <bungeman@chromium.org> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/main@{#927216}
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/97c19c5457ff..b8344e00b047 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC andypaicu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1234532 Tbr: andypaicu@google.com Change-Id: I6de951b8dbb1561d83346c63bb7e4bb2d1d614d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199485 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927217}
The metrics added in this CL record how often an enqueued message is not displayed on the screen immediately along with the reason it wasn't displayed (another message on the screen, message scope inactive). BUG=1250292 R=lazzzis@chromium.org Change-Id: I58ba47b129c603d17919a99bd53ae10e4f204fcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3195331 Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Reviewed-by: Lijin Shen <lazzzis@google.com> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/main@{#927218}
Currerntly index/length is directly passed to InputMethodAuralinux. However, it is interpreted as "before/after" of the selection. This CL fixes the gap. Note that, it is conflicting with wayland spec still. To fix it, both lacros/ash needs to be fixed atomically, so will be done separately. BUG=1227623 TEST=Ran on device. Change-Id: Iaa6e34327a66293ffbf51da19beb042ad0081479 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3194092 Reviewed-by: Darren Shen <shend@chromium.org> Reviewed-by: Eriko Kurimoto <elkurin@chromium.org> Reviewed-by: Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/main@{#927219}
vulkan.h is a surprisingly heavyweight header because it includes windows.h with all of the namespace pollution which that causes. This change replaces includes of vulkan.h with includes of vulkan_core.h, in ui/ozone. A larger set of files were updated in crrev.com/c/3191124 Bug: 1221278 Change-Id: I60b33854521ae0c1065ce7fa9a9442f0f2dc93d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198307 Reviewed-by: Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/main@{#927220}
https://android.googlesource.com/platform/external/perfetto.git/+log/c10e58491f2a..db4c45987622 2021-10-01 treehugger-gerrit@google.com Merge "UI: Update CSP, fix 'Wasm code generation disallowed by embedder'" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Idd00f505c0add4c6f7ac9732b1c278ca3ccb43c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198623 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927221}
For consistency with other functionality residing in both chrome/browser/ash/ and chromeos/components/, this CL migrates chrome/browser/ash/tether/ to the namespace used in chromeos/components/tether/, renaming chromeos to ash. This CL is part of the Chrome OS source code directory migration: https://docs.google.com/document/d/1g-98HpzA8XcoGBWUv1gQNr4rbnD5yfvbtYZyPDDbkaE. Bug: 1164001 Change-Id: Ic0bca69c432cd162e878a566157afd57239b3702 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3189721 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Owners-Override: Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/main@{#927222}
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/47e0ccea..007519c5 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel R=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia433453fff26f12386efe64983bbe09a5a28f23f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199498 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927223}
IPH promo is configured to trigger on detecting forward and backwards navigation from a search results page. Bug: 1236631 Change-Id: Ibab540dcf0182ca345f0ef747848f151165b1388 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3191025 Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by: Caroline Rising <corising@chromium.org> Commit-Queue: Roman Arora <romanarora@chromium.org> Cr-Commit-Position: refs/heads/main@{#927224}
Right now, there are too many mojom files lumped into mojom_platform, even though only code from core uses it. Moving these files into mojom_core better reflects the current layering and helps prevent C++ platform code from inadvertently depending on core concepts. * Remove unnecessary back forward cache mojom includes Bug: 1233167 Change-Id: Ic83b984c4f7d5bb91f1b99a8dc267f948d141127 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3194823 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Owners-Override: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/main@{#927225}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )