[pull] master from chromium:master #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
This has been launched on all platforms which were using the flag. Bug: 1253270 Change-Id: I5cb2a9af4fe6dc9f3877e3a97e6e2450a33389df AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3187957 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Mark Schillaci <mschillaci@google.com> Reviewed-by: Nektarios Paisios <nektar@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/main@{#927226}
Using wpt-import in Chromium b369163. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/css-sizing jsbell@chromium.org: external/wpt/resources NOAUTOREVERT=true R=rubber-stamper@appspot.gserviceaccount.com No-Export: true Change-Id: I55c86f62986b9aec8b60257e16f830a316b8e664 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199497 Auto-Submit: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927227}
crrev.com/c/3150470 introduced may_contain_annotations() as way to speed up scanning C++/Java source files by pre-filtering them. However, it doesn't pass the encoding="utf-8" parameter, causing issues with non-ASCII characters on Windows. Change-Id: Id42a877b9a85acfd8a6584be109d61bf50ea78e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3197879 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Igor Ruvinov <igorruvinov@chromium.org> Auto-Submit: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by: Igor Ruvinov <igorruvinov@chromium.org> Cr-Commit-Position: refs/heads/main@{#927228}
Bug: 1249622 Change-Id: I98c12e6189448c288dc61d024abab1d1e9249aa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3197719 Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/main@{#927229}
Printing conversion sizes are still of interest, particular given the recent introduction of yet another type for Type 42 fonts. OOPPD is still rolling out, so the number of drivers requiring elevated privileges is still of interest. There is still a high rate unknown PPD color models being reported, so it is still of interest to keep this around as more of these get addressed. Change-Id: If6a9802fe00d8528ecfb85b3102d5d8b4ded8a9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198939 Reviewed-by: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Auto-Submit: Alan Screen <awscreen@chromium.org> Cr-Commit-Position: refs/heads/main@{#927230}
They have been expired for 6+ months without any complaints. Bug: 1149505 Change-Id: I6e20b700d21b5aa66d33ca4cf765af521507cfda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3171501 Reviewed-by: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/main@{#927231}
This change enables the integration testing actions that check: 1) Is the intent picker icon shown, and 2) Is the intent picker icon not shown. This involves a little bit of refactoring because it was not possible for the test to wait for the intent picker logic to decide whether to show (or not show) the icon. The fix here is to: * Change the MaybeShowIntentPicker function to decide synchronously whether to show the icon or not, and return a boolean * Modify some of the helper code & ChromeOS code to facilitate this. Bug: 1145224, 1252607 Change-Id: Icc5e4007cbb01ab4a042400cf1481a3aa03d952a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3178669 Auto-Submit: Daniel Murphy <dmurph@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Reviewed-by: Phillis Tang <phillis@chromium.org> Reviewed-by: Maggie Cai <mxcai@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/main@{#927232}
This CL moves the code in this static member function to an anonymous function in HostContentSettingsMapFactory. This has the following benefits: 1. It removes a static member function that has no other callers and no other dependencies on ExtensionService. This is one more reduction in ExtensionService's status as a "dumping ground" for anything that's Extensions-related. 2. It reduces the dependencies in HostContentSettingsMapFactory, since it no longer depends on ExtensionService or ExtensionsBrowserClient. Instead, it now has a direct and clear dependency on CustomExtensionProvider and ContentSettingsService. Eventually, we want to clean up dependencies on Extensions API- specific directories, but this is a step in the right direction. Bug: 1251781 Change-Id: I5803360e3795c4faedea484aa4fd374bfd1a85ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3173738 Auto-Submit: David Bertoni <dbertoni@chromium.org> Reviewed-by: Martin Šrámek <msramek@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/main@{#927233}
A feature flag is added which will control whether extensions have their manifest version included in the CBCM report uploaded to DMServer. The flag is needed because server-side work is required for the manifest version reporting change. Once end-to-end implementation is complete, the flag will be removed. Bug: 1204508, b/201559564 Change-Id: I089a1a59c5a97a4bbd4981eda4a30b6db0d5684a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3192579 Reviewed-by: Owen Min <zmin@chromium.org> Commit-Queue: Igor Ruvinov <igorruvinov@chromium.org> Cr-Commit-Position: refs/heads/main@{#927234}
This is ensuring there will be an enough worker in the thread pool if there are still pending BLOCK_SHUTDOWN tasks. The problem we observed is that CONTINUE_ON_SHUTDOWN tasks are scheduled before the shutdown is started. Then, when shutdown is initiated, there is no available worker to run any BLOCK_SHUTDOWN tasks and the CONTINUE_ON_SHUTDOWN tasks needs to continue until their completion. The solution is to replace workers running CONTINUE_ON_SHUTDOWN tasks (similar to handling WILL_BLOCK). Such a task will allow max_tasks/max_best_effort_tasks to increase and create new workers for pending BLOCK_SHUTDOWN tasks. Note that we don't explicitly consider shutdown in GetDesiredNumAwakeWorkersLockRequired(), so we'd actually create workers for all pending tasks, limited to max_tasks. This aim to solve the same problem as https://chromium-review.googlesource.com/c/chromium/src/+/3085974 but this solution is preferred because it only acts during shutdown and covers tasks that don't have a ScopedBlockingCall. That CL is effectively reverted here to implement the preferred solution Bug: 1227930 Change-Id: I98a24bfc8264833f20ef9f679a8b5458925b836e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3072339 Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Auto-Submit: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/main@{#927235}
This field was mistakenly omitted in https://chromium-review.googlesource.com/c/chromium/src/+/3086144 and https://chromium-review.googlesource.com/c/chromium/src/+/3137574 Bug: 1238577 Change-Id: I8b938c799fb534101c3472b26a228d45808cab52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3197993 Reviewed-by: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by: Daniel Rubery <drubery@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/main@{#927236}
This CL makes the following changes: 1. Add the frameSeqId argument to the test BeginFrame and DrawFrame events in frame-model.js to match the change in https://crrev.com/c/3010396. 2. Modify expected test result to reflect the change regarding frame alignment in DevTools frontend (https://crrev.com/c/3083645). Bug: 1192637 Change-Id: I3eb267740b61a7235ee36571ba5b8ac483ab2489 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3083541 Reviewed-by: Paul Lewis <aerotwist@chromium.org> Commit-Queue: Mingjing Zhang <mjzhang@chromium.org> Cr-Commit-Position: refs/heads/main@{#927237}
base::TimeDelta::FromMilliseconds[D]() is being migrated to base::Milliseconds(), which automatically detects integral versus floating-point arguments. The network config code previously passed a double to the integral conversion function, which results in truncating any fractional part but does retain higher bit depth. To make the upcoming change a no-op, call the double function instead. This exposed that the value used in the test, which is thousands of years in the future, results in minor precision loss with this function (on the order of half a millisecond). Change the test to drop one digit, resulting in a time value around the year 1992, a much more reasonable magnitude of test value. This avoids the test failure. Bug: 1243777 Change-Id: Ib2f699b07b9a6ce1b95d53fca59feb4aacdcf7b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200011 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/main@{#927238}
Fix StartReadingTest to verify the correct data was read by the reading process, instead of verifying the input (producer) data. Bug: none Change-Id: I7b919928849e3b2456ebf6d2e2f74df56fdc1f17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3194771 Reviewed-by: Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/main@{#927239}
This helps alert Voiceover users that something has changed when a password is generated. There are also 2 other small acessibility fixes in this CL based on recommendations from the accessibility review. First, the placeholder had too low contrast with the background, so was unreadable for some users. This increases the contrast. Second, there was a small bug with setting the accessibility label on the hide/show password icon, resulting in the label not being set on initial load of the view. Bug: 1254797 Change-Id: I3d7e2fb765bb4d8665290f672225ec0e0f0cbdf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198251 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/main@{#927240}
Release_Notes: http://go/projector_app-x20/relnotes/Main/projector_app_nightly_202110010100_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/projector_app/app/+/VFt77gp6mApLFyr58ZNOH35IqcHVK6KZbWVdeQlsEGgC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/projector-app-chromium-autoroll Please CC cros-projector-oncall@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chrome.try:linux-chromeos-chrome Bug: b/195465466 Tbr: cros-projector-oncall@grotations.appspotmail.com Change-Id: I396dd1bb396e92196ba596ba94cc22321369e491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199692 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927241}
This adds a new ShouldBlockUpdate() function that allows us to add logic to block the update if needed. On Windows, if the device is on metered connection, we will block background updates so the device will not auto-update. However, if it's a foreground update, we still allow it to continue. Change-Id: Ie4261c2e9d4f551d28f2a4b246bff18095f35731 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3187655 Reviewed-by: Sorin Jianu <sorin@chromium.org> Reviewed-by: Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Colin Tan <colta@microsoft.com> Cr-Commit-Position: refs/heads/main@{#927242}
Bug: n/a Change-Id: Ife10ac745a1842f1321690b8f6e97671c75f0ff7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3176341 Reviewed-by: Abigail Klein <abigailbklein@google.com> Commit-Queue: Valerie Young <spectranaut@igalia.com> Cr-Commit-Position: refs/heads/main@{#927243}
This CL reflects the change of the specification when the current character set is OTHER. The behavior has been changed when the last character set is full-width uppercase alphabet or half-width. Bug: 1195393 Test: ChromeVoxPhoneticDataTest Change-Id: Ie965698c732e66ccf3501ffefc9b3f85a77faedb AX-Relnotes: n/a. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198271 Reviewed-by: Hiroki Sato <hirokisato@chromium.org> Reviewed-by: Akihiro Ota <akihiroota@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/main@{#927244}
Bug: 1252196 Change-Id: I15c56b9e55a0252d35cf55f6a62bd07d11268575 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198078 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Auto-Submit: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/main@{#927245}
Bug: 1254923,1186444 Change-Id: I5c03fef5c2388b55b507651fd3f9d9bf7468d4bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199211 Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Caleb Raitto <caraitto@chromium.org> Cr-Commit-Position: refs/heads/main@{#927246}
Floating-point values should be passed to FromMillisecondsD(), not FromMilliseconds(). This in turn requires test changes to increase the expected precision from millisecond to microsecond. This was exposed by the upcoming migration of both FromMilliseconds() variants to base::Milliseconds(), which accepts both integral and floating-point values and auto-switches using a template. This change makes that conversion a no-op. Bug: 1243777 Change-Id: I46fce6a8bda81b61d33cd115d57a561c6f7ed36f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198864 Commit-Queue: Gary Kacmarcik <garykac@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by: Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/main@{#927247}
https://swiftshader.googlesource.com/SwiftShader.git/+log/1cdfcb680631..caffd15fa261 2021-10-01 capn@google.com Remove the legacy GLSL ES vertex shader fuzzer If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-eng+autoroll@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-eng+autoroll@google.com Change-Id: I9ff3c1198af336aee2327b033b7b92f4918d9123 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199728 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927248}
https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/a002c725cf03..10eb9982ffef 2021-10-01 daniel.kiss@arm.com [libunwind] Fix cfi_register for float registers. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/libunwind-chromium Please CC thakis@chromium.org,hans@chromium.org on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: thakis@chromium.org,hans@chromium.org Change-Id: I7c5ddc943a6360c790d38dd7171484f22692c526 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198625 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927249}
https://chromium.googlesource.com/chromiumos/chromite.git/+log/b11c70071c61..ef3bc2f831fe 2021-10-01 deanliao@chromium.org cros_bisect: Remove the deprecated cros_bisect tool 2021-09-30 bpastene@chromium.org chrome_committer: Don't CQ+2 the uploaded CL by default. 2021-09-30 kimjae@chromium.org cgpt: paygen: Execute 'cgpt' depending on binary existence 2021-09-30 saklein@chromium.org utils/timer: Add a small timer utility class If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: Ia6576b8c6f6212e5a1458e7aaf5b3411b4ec1c55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199081 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927250}
This reverts commit 1ec60fb. Reason for revert: the test flakily times out on nearly every run For example on https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.13%20Tests/42620 See also https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=blink_web_tests&tests=external%2Fwpt%2Fevent-timing%2Fclick-interactionid.html Original change's description: > Add a wpt for interaction id. > > This CL is for adding a wpt to check if we assign correct interaction > ids when we click. > > Bug: 1236758 > Change-Id: I0c6fad3ef9301fc54868f4aee01507e7142d14e4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3197873 > Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> > Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> > Cr-Commit-Position: refs/heads/main@{#927211} Bug: 1236758 Change-Id: Ic719403bc45cbfca3ef96717cae79878c20ed234 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198867 Auto-Submit: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927251}
Automatic update for 2021-10-01 UTC Change-Id: Id6c26d2e97d010664b8fc40403c9b670aa1082bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198865 Commit-Queue: CT Log list updates bot <mdb.chrome-pki-metadata@google.com> Bot-Commit: CT Log list updates bot <mdb.chrome-pki-metadata@google.com> Cr-Commit-Position: refs/heads/main@{#927252}
on a new object It switches to a slightly more complicated logic running behind the scene than it could be, but it makes children computation lazy which is good for performance and it shares common code path, wcich increases code reliability. Follow up from CL 3187031. Change-Id: I778240a874413fa349507307f1d87c908a04431a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3192419 Reviewed-by: Nektarios Paisios <nektar@chromium.org> Commit-Queue: Alexander Surkov <asurkov@igalia.com> Cr-Commit-Position: refs/heads/main@{#927253}
There is not always a preflight result to log at the point where AddEvent() was called. The new test aims to demonstrate this. This crash is relatively new, it was introduced in crrev.com/c/3161097 on 2021-09-22. Change-Id: I7c069430dbb3bff6863d3ac4623bdca2e393dd4b Fixed: chromium:1255123 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3197687 Commit-Queue: Titouan Rigoudy <titouan@chromium.org> Auto-Submit: Titouan Rigoudy <titouan@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/main@{#927254}
Bug: 1207317 Change-Id: I5b7b809c6c0d81f502e2e4a10f7f4f99a9eb822d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199550 Reviewed-by: Oriol Brufau <obrufau@igalia.com> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/main@{#927255}
Roll Chrome Win64 PGO profile from chrome-win64-main-1633100354-2e6443e43e22e09dc2ebc5467e0536890c7509e5.profdata to chrome-win64-main-1633111193-17ce088b5cc636487cc941e44ddba2d24676dd87.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie253ab8344231d469148e7db85dba357f3e3fc2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200234 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927373}
Screenshot: https://screenshot.googleplex.com/5M2wrnT6o5YQVTm Run browser tests for Shimless* autoninja -C out/Default/ ash/webui/shimless_rma/resources:closure_compile_module autoninja -C out/Default/ chrome/test/data/webui/chromeos/shimless_rma:closure_compile Bug: 1198187 Test: Run local build. Change-Id: I06d7a0c25791394401b313910a6e80b6356fe4a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3182870 Commit-Queue: Gavin Dodd <gavindodd@google.com> Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/main@{#927374}
This is the behavior on other platforms. Bug: 1254234 Change-Id: I44202d4833e4a4394f34d7c15197b6dedeb63c2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3197718 Auto-Submit: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/main@{#927375}
This reverts commit 96c964b. Reason for revert: It's breaking symbol upload, see crbug.com/1254992 Original change's description: > Migrate Clang's package.py and tools/symsrc/ to Python3 > > This should remove the last dependency on third_party/pefile > which is Python 2. > > (This co-depends on a CL to switch the Clang packaging buildbots > to run package.py under Python 3: https://crrev.com/c/3194137) > > Bug: 1213186 > Change-Id: Ia5fa42ec2012900058a6ce11bc75cbded15ad052 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3194354 > Reviewed-by: Bruce Dawson <brucedawson@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Hans Wennborg <hans@chromium.org> > Cr-Commit-Position: refs/heads/main@{#926673} Bug: 1213186, 1254992 Change-Id: Ia577f817e39eb6c74f8fb795645d7a60805f8273 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198497 Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/main@{#927376}
https://chromium.googlesource.com/angle/angle.git/+log/2a8be9de18ea..0b4508e5d917 2021-10-01 jmadill@chromium.org Add script to automatically download extension data. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: I1ac50407784e09eabef03fa83e258d9c4f820716 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200218 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927377}
This reverts commit cc5a8ac. Reason for revert: Test crashes on Android Pie bot Sample failing test run https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-rel/6303 Original change's description: > [MPArch] Test prerendering crash in subresource filter > > The sequence of events: > > 1) Page A starts a prerender to page B > 2) Page B creates an AsyncDocumentSubresourceFilter for its main RFH > 3) Page B navigates a cross-origin subframe > 4) Because it's cross-origin in a prerender, the > PrerenderSubframeNavigationThrottle defers the subframe navigation > at WillStartRequest. > 5) The user now navigates to page B causing a prerender activation > 6) The prerender activation creates a main frame, cross-document > navigation in the primary frame tree. This doesn't run navigation > throttles but the ContentSubresourceFilterThrottleManager sees this > as a regular navigation in the main frame and creates a new > AsyncDocumentSubresourceFilter for the navigation's RFH. Because > prerendering activation only moves a page from the prerender frame > tree into the primary frame tree, the RFH is preserved so this is > the same RFH as in step #2 > 7) CSFTM keeps track of AsyncDocumentSubresourceFilters in a > RFH->Filter map. So the new filter overwrites the one created in > step #2. This deletes the first filter since the map owns it. > 8) Now that the prerendering page has entered the primary frame tree, > the subframe navigation from step #4 is resumed. > 9) The subframe navigation runs the > SubframeNavigationFilteringThrottle, which was created in step #3 > and has a raw pointer to the AsyncDocumentSubresourceFilter from > step #2. However, this filter was deleted in step #7 so this points > to freed memory. The throttle calls a method on this bad pointer and > we eventually crash somewhere. > > This issue is fixed in https://crrev.com/c/3018307 by making each > throttle manager responsible for a single page. This CL only adds a test > for this specific situation. > > A small note about the test, we changed from registering throttles in > DidStartNavigation to the ContentBrowserClient. > RegisterThrottleForTesting adds throttles to the end of the throttle > runner which meant we run a different throttle ordering in tests. In > particular, the reproduction required that the > SubframeNavigationFilteringThrottle run WillStartRequest before being > blocked on prerendering in step #4, before the filter was overwritten. > Using RegisterThrottleForTesting meant it would only be run after the > prerender was activated. > > Bug: 1203614 > Change-Id: I24ab77a04b9032933cfa45a167145139465c58ea > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3033462 > Commit-Queue: David Bokan <bokan@chromium.org> > Reviewed-by: Josh Karlin <jkarlin@chromium.org> > Reviewed-by: Charlie Harrison <csharrison@chromium.org> > Cr-Commit-Position: refs/heads/main@{#926616} Bug: 1203614 Change-Id: I867c0641701cde250e9c3860dc787a4c32b4a81d Owners-Override: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199971 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/main@{#927378}
Bug: 1255221 Change-Id: Icedf82648e03e3b0d589cce6f9bcc07f76522d95 No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3197377 Auto-Submit: Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927379}
The test http/tests/devtools/tracing/frame-model.js was previously disabled to allow for the landing of https://crrev.com/c/3083645. The current CL re-enables the test after the fix by https://crrev.com/c/3083541. Bug: 1192637 Change-Id: I72267019f78af3d8ab33b5338030d89f0bed1d36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200112 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Mingjing Zhang <mjzhang@chromium.org> Cr-Commit-Position: refs/heads/main@{#927380}
configurations for new builder based off of Chrome release tags on Mac ARM Bug: 1210373 Change-Id: I25d875b17e134fd2455f63fbc5724b66c6b48bac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200019 Auto-Submit: Wanda Mora <morawand@google.com> Reviewed-by: Michael Moss <mmoss@chromium.org> Commit-Queue: Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/heads/main@{#927381}
This version of IntrusiveHeap is a thin wrapper around a general-purpose IntrusiveHeap that simply changes it from a max-heap to a min-heap that uses the <= operator. The same functionality can be achieved by using the general-purpose IntrusiveHeap and using the std::greater comparator. This avoids the need for types to invert the definition of their comparison operator (like PendingTask::operator<() used to do). Bug: 1254916 Change-Id: I6cf653b8446aa5afbe87dd27bbc0ae07d00752b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199210 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/main@{#927382}
The previous implementation manually manipulated bits via raw uint32. The goal is to improve type safety. Note that mojo does not support bitsets, so we maintain the conversion logic. Bug: 1221662 Change-Id: If80603782402f50d63b94a3d78596dc72a8917e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3196791 Commit-Queue: Matt Reichhoff <mreichhoff@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Reviewed-by: Steven Bingler <bingler@chromium.org> Cr-Commit-Position: refs/heads/main@{#927383}
We want to gather metrics when we are migrating the main account hash from v2 to v3. This metric is sent to gather whether the migration was successful or not. Android change: http://ag/15926277 Bug: b:187050911 Test: Manual, verified on chrome://histograms Change-Id: I5123aedebf5037b428367e8b63cd40f62049121c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3180262 Reviewed-by: Alex Gough <ajgo@chromium.org> Reviewed-by: Muhammad Hasan Khan <mhasank@chromium.org> Reviewed-by: Shao-Chuan Lee <shaochuan@chromium.org> Reviewed-by: Yury Khmel <khmel@chromium.org> Commit-Queue: Varun Somani <vsomani@google.com> Cr-Commit-Position: refs/heads/main@{#927384}
This reverts commit e263944. Reason for revert: Higher Z-order floats IPH above other application windows; this is a regression Original change's description: > IPH: Make Mac z-order consistent with other platforms > > On Mac, IPH bubble renders below omnibox popover but above omnibox text, > creating a glitchy visual. This elevates the z-order of the IPH bubble > slightly on Mac so that the visual effect is the same as on Windows, > Linux, etc. - the IPH bubble pops over other UI elements. > > Since most IPH bubbles either time-out or can be easily dismissed by > the user, this provides an acceptable experience. > > See attached bug for more information. > > Bug: 1225046 > Change-Id: Id38b5787882d086eb9584f715be0caaf914318bc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3194782 > Commit-Queue: Dana Fried <dfried@chromium.org> > Commit-Queue: Emily Shack <emshack@chromium.org> > Auto-Submit: Dana Fried <dfried@chromium.org> > Reviewed-by: Emily Shack <emshack@chromium.org> > Cr-Commit-Position: refs/heads/main@{#926433} Bug: 1225046 Change-Id: Id7abfddcb8e8588dd2ec489c988f2854156d7a13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199975 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/main@{#927385}
This is a minimal change to restore the updater to working order, but probably there is more work that could be done on the response parser in the long term. Fixed: 1255119 Change-Id: I00bdf1a6638e54a4c40226d1bca229eccbeacd68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198215 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/main@{#927386}
Roll Chrome Win32 PGO profile from chrome-win32-main-1633100354-28c73e357a900b658117e17f2215682c7a8fabb2.profdata to chrome-win32-main-1633111193-16c39b1f1441cfedd422f3e60feeedde77a917d0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I44d14061af551574a95366769e62c412cd0582d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200371 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927387}
Bug: 1255230 Change-Id: I37d2dd607b413d2ddcf426fe826dae00c704907c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199271 Owners-Override: Adithya Srinivasan <adithyas@chromium.org> Auto-Submit: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/main@{#927388}
Bug: 1184053 Change-Id: I04f54cf17f65eb032a5ea6aaae971921122218fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3195533 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/main@{#927389}
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3c323ba83a4a..33f6544acc66 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mek@google.com,adithyas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1255076 Tbr: mek@google.com,adithyas@google.com Change-Id: Ia1caef9151d9efbb151476020c0f515a8b936495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200370 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927390}
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/43bb1982..8d3b3d88 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel R=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibcb1f52ca5c40be25eb0f58df1be45a70b3ebe59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200350 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927391}
Address comments at https://crrev.com/c/3163422. Bug: 1249937 Change-Id: I65b54a9eea9071e477e02d2d6a485987244b6c2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199035 Commit-Queue: Sophie Wen <sophiewen@google.com> Reviewed-by: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/main@{#927392}
These tests are also already disabled on most other Android emulators test bots. Bug: 1046060, 1191793, 1191795 Fixes: b:201766090 Signed-off-by: Chidera Olibie <colibie@google.com> Change-Id: I4ade6701370f011f904ab15cd11e52ef34ae7b64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198077 Reviewed-by: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/main@{#927393}
ArcBluetoothBridge needs a migration away from BlueZ to work with Floss. For now we disable it to avoid crash. Bug: b:201701784 Change-Id: I9391205fc77ba5e27c7a28b06f5f6a29468ac587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198808 Reviewed-by: Josh Horwich <jhorwich@chromium.org> Reviewed-by: Yusuke Sato <yusukes@chromium.org> Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Cr-Commit-Position: refs/heads/main@{#927394}
Minimum height test: After scrolling all the way down with feed turned off, ensures that doodle is not visible and that fake omnibox is still visible. Previously would only test if tiles were visible. Feed visible/enabled tests: Also verifies if NTP is scrollable after toggling feed visible/hidden and enabled/disabled. Extracts commonly used tests into functions and uses them across several tests. Bug: 1194106 Change-Id: I7798b903a2c68d027dbb084b831391489f35a4f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3197639 Reviewed-by: Sergio Collazos <sczs@chromium.org> Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Cr-Commit-Position: refs/heads/main@{#927395}
After approval for launch, This CL enables BackForwardCache on the tip of the tree by default for Desktop. [BFCache-Opt-In] BFCache-Opt-In header will be ignored by default on Desktop. Here is the code location. https://source.chromium.org/chromium/chromium/src/+/main:content/browser/renderer_host/back_forward_cache_impl.cc;l=146 [Intent to Ship] https://groups.google.com/a/chromium.org/g/blink-dev/c/RwWG-z4i_PU/m/CFTRWrrnAQAJ?utm_medium=email&utm_source=footer Bug: 1171298 Change-Id: Ia80273944c21aea5409909e343cb6b2afead8062 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198063 Reviewed-by: Alexander Timin <altimin@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/main@{#927396}
These 3 tests fail on AMD, Intel, and Apple M1 when the direct Metal backend is in use. Suppress the failures until fixed. Bug: angleproject:6489 Bug: angleproject:6486 Change-Id: I3bb65b9451224e589632eac69571c4fbb77026be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3197376 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Cr-Commit-Position: refs/heads/main@{#927397}
This is the first usage of the presenter. I also tried hooking it up to the model observer, but there are a couple discrepancies between the sync backend and the local storage backend. Bug: 1253640 Test: manual, added test Change-Id: I46eef0ed8b9c54066b1a575b6b8109ce4b20dc10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200022 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/main@{#927398}
This fixes the compareWithPerspective comparison function in transform-interpolation-001.html to accept values with scientific notation (such as numbers very close to zero). It also fixes the comparison function to handle errors better so that failures are reported more clearly. (I want to do this here because the following patch would otherwise add two more of these failures, for the CSS transitions at time 0 cases.) Bug: 897358 Change-Id: Id1ecde987eb0ba9d0d00b6da030d74a689c1e502 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199697 Commit-Queue: David Baron <dbaron@chromium.org> Reviewed-by: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/main@{#927399}
Bug: 1254717 Change-Id: Id117b9f05ed6fee8a5bb2bf0714690da4a0d3d6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199055 Auto-Submit: Chong Gu <chonggu@google.com> Reviewed-by: David Dorwin <ddorwin@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/main@{#927400}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )