[pull] master from chromium:master #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
…0473681-1 Ran `./tools/clang/scripts/upload_revision.py d047368149dc3084774db618051346c045a2f645`. Bug: 1254822 Change-Id: I641869d4e3c89b1f83e3630c42d0029d8cbb42e1 Cq-Include-Trybots: chromium/try:android-asan Cq-Include-Trybots: chromium/try:chromeos-amd64-generic-cfi-thin-lto-rel Cq-Include-Trybots: chromium/try:dawn-win10-x86-deps-rel Cq-Include-Trybots: chromium/try:linux-chromeos-dbg Cq-Include-Trybots: chromium/try:linux_angle_deqp_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_cfi_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_msan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_compile_dbg_32_ng Cq-Include-Trybots: chromium/try:linux_chromium_msan_rel_ng Cq-Include-Trybots: chromium/try:mac11-arm64-rel,mac_chromium_asan_rel_ng Cq-Include-Trybots: chromium/try:win-asan,win7-rel Cq-Include-Trybots: chromium/try:android-official,fuchsia-official Cq-Include-Trybots: chromium/try:mac-official,linux-official Cq-Include-Trybots: chromium/try:win-official,win32-official Cq-Include-Trybots: chrome/try:iphone-device,ipad-device Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Cq-Include-Trybots: chrome/try:win-chrome,win64-chrome,mac-chrome Cq-Include-Trybots: chrome/try:linux-pgo,mac-pgo,win32-pgo,win64-pgo Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199571 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/main@{#927519}
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Disable-Retries: true Change-Id: If143c1346b0f238201364ff9907f87ab13684b87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200378 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927520}
Using wpt-import in Chromium e673a70. With Chromium commits locally applied on WPT: 6e7e392 "[GridNG] Invalidate when alignment changes on OOF elements" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/css-flexbox NOAUTOREVERT=true R=rubber-stamper@appspot.gserviceaccount.com No-Export: true Change-Id: Iceaea2597a42cbab503059095e5a6c91c14010ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3197463 Auto-Submit: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927521}
- Rename the name from certificateFingerprints to certificateHashes. - Define WebTransportHash whose value property's type is BufferSource. Ideally we should pass the binary data to the network service instead of stringified data, but I'd like to keep the mojo interface not to break things. Hopefully we'll be able to update the implementation in the future. Bug: 1011392 Change-Id: Ifc68866cc32e7619be09e43a7bd240e95831896d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199951 Reviewed-by: Victor Vasiliev <vasilvv@chromium.org> Reviewed-by: Adam Rice <ricea@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/main@{#927522}
…nnerManager Most uses of IsInMainFrame have been converted to IsInPrimaryMainFrame for MPArch. As one of ensuring that the conversion is correct, this CL ensures prerendering does not update the state of AppBannerManager. Bug: 1218946 Change-Id: I4702e0a39d59cc1c9c2ab3db4cbb201358022927 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198101 Reviewed-by: Kevin McNee <mcnee@chromium.org> Reviewed-by: Daniel Murphy <dmurph@chromium.org> Reviewed-by: Glenn Hartmann <hartmanng@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/main@{#927523}
https://chromium.googlesource.com/angle/angle.git/+log/12e5a7db66ac..0d9568093dda 2021-10-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from 5d72b170aad6 to e2aeccde416b (13 revisions) 2021-10-01 ianelliott@google.com Fix links with Handling Test Failures CL 2021-10-01 ianelliott@google.com Suppress VUID-RuntimeSpirv-OpImage-06376 2021-10-01 gman@chromium.org Update ANGLE_robust_resource_initialization about depth 2021-10-01 gman@chromium.org Fix Metal backend not clearing stencil buffer 2021-10-01 ianelliott@google.com Add documentation about suppressing test failures If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: I146141a858516ca1509768fc3ec2d2486a26c3f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200732 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927524}
Change-Id: Ida7803fb96d1cc753de1662793909518463f5ef4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200712 Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927525}
Also handles new field provided by API which does not require a token Bug: 1230867 Change-Id: If9917c72fc2cc3ed27539d0924e7853f1526f52b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200254 Auto-Submit: Jeremy Selier <jerem@google.com> Commit-Queue: Jeremy Selier <jerem@google.com> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/main@{#927526}
Delays calls to the unseasoned plugin's postMessage() method before the initial 'connect' message from the plugin. Otherwise, these calls will fail due to the undefined postMessage() method. Also refactors handleScriptingMessage() to avoid a duplicate 'connect' message caused by confusing the 'connect' message with a scripting message from the embedder. Bug: 1228987 Change-Id: Ib8bc1f55e06bc69d7777fc6b68ff0b07a3a040d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200186 Auto-Submit: K. Moon <kmoon@chromium.org> Reviewed-by: Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: K. Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/main@{#927527}
Automatic update for 2021-10-02 UTC Change-Id: I35927646ddbcd5f53ecc3afa6e12c5f20d9a98ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3197863 Commit-Queue: CT Log list updates bot <mdb.chrome-pki-metadata@google.com> Bot-Commit: CT Log list updates bot <mdb.chrome-pki-metadata@google.com> Cr-Commit-Position: refs/heads/main@{#927528}
The result of OmniboxResourceProvider#getSuggestionPrimaryTextColor, a ColorInt, was being passed to Resources#getColor(), expects ColorRes, even though it should be used directly. This CL fixes this by removing the getColor() part. Bug: 1255299 Change-Id: I1af8c65e2b6caef1ceacc8c4bda31aeb33e051ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200559 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/main@{#927529}
- Displays paper-spinner and hides network-icon when network is in connecting state. - Tests that correct icon is displayed when state is connecting. Screenshot: http://shortn/_3604SWtOjE --gtest_filter=DiagnosticsApp* Bug: 1197335 Test: testing/xvfb.py out/Default/browser_tests Change-Id: Ia1ad09a86969c56a55988cb852322943491e2dd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199230 Commit-Queue: Ashley Prasad <ashleydp@google.com> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/main@{#927530}
This CL resets the HIDDevice mojo receiver when the close() method is called and when open() fails. Previously it was not reset, which caused a DCHECK failure when trying to re-bind the receiver. Bug: 1254973 Change-Id: I0e087faa6bd23f6c4bceaee8c603bf26ab035eb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200522 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/main@{#927531}
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Disable-Retries: true Change-Id: I5be7c020d1e3eb39ef10194ebb5e872e90b80d6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200582 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927532}
https://chromium.googlesource.com/external/github.com/AOMediaCodec/libavif.git/+log/f131b785938e..0dd3a3a5d216 $ git log f131b7859..0dd3a3a5d --date=short --no-merges --format='%ad %ae %s' 2021-10-01 wtc Improve detection of libyuv integer overflow bugs Created with: roll-dep src/third_party/libavif/src R=jzern@chromium.org,pkasting@chromium.org Change-Id: If389d2eb3dffc650b6c09c3b80689cd58006ba05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200637 Reviewed-by: James Zern <jzern@google.com> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/main@{#927533}
https://skia.googlesource.com/skia.git/+log/906e9eb53841..ce22e059ffeb 2021-10-02 reed@google.com pulling the plug If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: csmartdalton@google.com Change-Id: Icbb8e1b6d2692528de92d834a17530ea9dfe451a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200656 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927534}
Helper class implementation. Add an abstract helper class in //component/content_settings to monitor site settings changes and update user pref for global feature settings. === This CL is a fast work-around which support to mirror content settings with theme settings. While JNI content observer is preferred, having this workaround would make sure we'll have something functional for M96 branch. Bug: 1241542, 1250445, 1252504 Change-Id: I35e15d020dceed4b5c16a39e02c8e4dcb49d1820 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3173788 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/main@{#927535}
This patch migrates the global ReportBadMessage(), GetMessageCallback() to their respective equivalent on mojo::Receiver. Bug: 1213505 Change-Id: I9d8f854b1910540de991a7bb36e48e08f250fe4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3192882 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/main@{#927536}
Bug: 1230867 Change-Id: Ibe0ad091bf1e61bd5a49749b36c849d6b2a074cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200399 Commit-Queue: Jeremy Selier <jerem@google.com> Auto-Submit: Jeremy Selier <jerem@google.com> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/main@{#927537}
This CL updates the ash version 96.0.4660.0 for Lacros version skew testing. If this CL caused regressions, please revert and stop the autoroller at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller Also please file a bug to OS>LaCrOS>Partner, and CC svenzheng@chromium.org, liaoyuke@chromium.org, yjt@google.com. R=rubber-stamper@appspot.gserviceaccount.com Bug: None Change-Id: I4e43c8e5154a41d72be8ace77857b28b072f97b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3197387 Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927538}
Change-Id: I2571e2e31e642d47ebf03196be8b00d213b4df09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198720 Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927539}
Change-Id: Ib05cec7e2a0a8423c978cf0859a3cc506fff968e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200872 Auto-Submit: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/main@{#927540}
Setting a new override name won't automatically result in the new name being announced. Do so explicitly. Bug: 1251786 Change-Id: I58c350aedfcdb51901b3799b7f4c904bb4897941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200678 Commit-Queue: David Black <dmblack@google.com> Reviewed-by: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/main@{#927541}
Remove Value::CreateDeepCopy(). Existing usages replaced with Value::Clone(). Bug: 1187013 Change-Id: Ie599568847e58ebf45558a39c500cc18ab5b4373 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3201010 Reviewed-by: Austin Sullivan <asully@chromium.org> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/main@{#927542}
This CL moved Bluetooth device battery info UI element to cr_components/ folder. Bug: 1252935 Change-Id: Ie341af3efa9ae286b885137a4c0237a007982f98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199130 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: Gordon Seto <gordonseto@google.com> Cr-Commit-Position: refs/heads/main@{#927543}
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Disable-Retries: true Change-Id: I3144cb6d856468b94a90e46b07c9110c2c5e7475 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200951 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927544}
ProductivityLauncher in clamshell mode uses as scrollable grid without pages. Likewise, folders are scrollable. When reordering apps, only announce the row and column, not the page. This eliminates a confusing "page 1" from the announcements. AX-Relnotes: n/a. Bug: 1254510 Test: added to browser_tests Change-Id: I67fbe11f0f6b14614955ad1b147841069ad8fc63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200558 Reviewed-by: Toni Barzic <tbarzic@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/main@{#927545}
https://chromium.googlesource.com/angle/angle.git/+log/0d9568093dda..d3764f080f6c 2021-10-02 kpiddington@apple.com Fix dEQP.GLES3/functional_fragment_out_array* on Direct to Metal 2021-10-02 mprzybyl@google.com Revert "VertexArray: Don't syncState on Buffer map/unmap." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: I9b9cdcfd3b8c5e9f4b7e03116b21e9eb626d4fbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200924 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927546}
Currently, the forced sign-in screen can only be presented on the browser view controllers (incognito tab or regular tab), because interfaceProvider.currentInterface.viewController only provides the browser view controller used on the current browser interface. TabGridViewCoordinator.activeViewController provides the view controller that is really active. For example, activeViewController will provide TabGridViewController when the active view is the regular tab switcher. Tested on each surface: incognito tab, incognito tab switcher, regular tab, regular tab switcher, and recent tabs. See http://shortn/_fBkQ0PBzFB. Bug: 1250761 Change-Id: I3008535b6f715a704c2d6592de6609cb4d58ee21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3188491 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Vincent Boisselle <vincb@google.com> Cr-Commit-Position: refs/heads/main@{#927547}
This CL fixes a bug that was due to UpdateTreeOfRendererFrame() erroneously assuming that frames removed from FormData::child_frames have been or will be destroyed. Frames may also be removed from FormData::child_frames because they have become invisible. In such a case, this CL unsets the removed frame's FrameData::parent_form. That way, the former parent's FormData::child_frames and the former child's FrameData::parent_form are consistent. As far as I can tell, this bug had no relevant consequences. To keep the code simple, this CL does not push the fields that originate from forms in the child's subtree to the child. The fields are simply deleted, and only restored upon the next reparse of the forms in the child's subtree. Pushing the fields to the child's subtree is possible by tweaking UpdateTreeOfRendererForm()'s tree traversal, but it does add some further complexity. Bug: 1187842, 1187857 Change-Id: I8fd7791e93609b1cf27cdc99eb917080c0f549c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3190490 Commit-Queue: Christoph Schwering <schwering@google.com> Reviewed-by: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/main@{#927548}
TimeRecordedWhenRendererIsKilled is flaky under TSan: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20TSan%20Tests/69878/overview Bug: 1255492 Change-Id: I346034978badf0ee77ad51c9a7dc3d1e0a361521 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3201100 Owners-Override: Johann Koenig <johannkoenig@google.com> Reviewed-by: Yuki Yamada <yukiy@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/main@{#927583}
Bug: internal b/189446805 Test: local build Change-Id: Ia2da33bccb36fd6cd0159953216af912b62e55d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3192884 Reviewed-by: Luke Halliwell <halliwell@chromium.org> Commit-Queue: Yuqi Sun <sunyq@google.com> Cr-Commit-Position: refs/heads/main@{#927584}
…ary page This CL introduces a test that ensures SafeBrowsingUserInteractionObserver doesn't record the metrics in prerendering. It also cleans up the TODO comment about a primary page from user_interaction_observer.cc. Bug: 1218946 Change-Id: Id73cf21f4b80f2d693b2255c32b419b978f60149 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3194410 Reviewed-by: Kevin McNee <mcnee@chromium.org> Reviewed-by: Daniel Rubery <drubery@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/main@{#927585}
TestLoggingWithNoPageEndWithNoFirstBackgroundTime is flaky under TSan: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20TSan%20Tests/69869/overview Bug: 1255496 Change-Id: I7a26116e5353550179537ba540547482f08b5505 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3201102 Reviewed-by: Yuki Yamada <yukiy@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Owners-Override: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/main@{#927586}
This CL disallows mojo unions from being self-recursive and it
checks if the type name is same as mojo name at translate.py.
It is a prerequisite CL to [1] that removes ScopedDepthTracker
from ValidateInlinedUnion() and ValidateNonInlinedUnion() since
it causes redundant depth validation for base::Value type.
It adds a test to ensure that a union is not self-recursive to
translate_unittest.py.
The tests can be run locally with:
python -m unittest discover \
-s mojo/public/tools/mojom/ -p "translate_unittest.py"
[1] https://crrev.com/c/3154109
Bug: 1246320
Change-Id: I2091238d0ac9fd82e9e70d88bc87507d4e67a13c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3195680
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Julie Kim <jkim@igalia.com>
Cr-Commit-Position: refs/heads/main@{#927587}
Change-Id: I44166b424c228c7e15c9c07263a5493bab078d40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200332 Reviewed-by: Ali Beyad <abeyad@chromium.org> Commit-Queue: Mike Taylor <miketaylr@chromium.org> Cr-Commit-Position: refs/heads/main@{#927588}
Roll Chrome Win64 PGO profile from chrome-win64-main-1633305549-56e326d370f154755719626349887baf0f3a3f85.profdata to chrome-win64-main-1633313891-048cc93a982a2256fc2374370d70dfd7d2e603c7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6aa5d32e8a5731f395f2b0b49cb21ae5c42fdebb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3201850 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927589}
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/01a30b7c81d9..3497a970ea9c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC johannkoenig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: johannkoenig@google.com Change-Id: I5a4c6645befab81badc0cd877d4b65473ce35407 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200660 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927590}
Roll Chrome Win32 PGO profile from chrome-win32-main-1633305549-cf6aaed74af10ffdf431a2884209ff71f3989cd6.profdata to chrome-win32-main-1633313891-dc76ccf42e8816f3c6809b396d551b1ed90c8357.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ia55064881d608cdcaf65c970d7cd15f04fe161bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3201851 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927591}
This test is flaky on Win7: https://ci.chromium.org/ui/p/chromium/builders/ci/Win7%20(32)%20Tests/72608/overview Bug: 1248459 Change-Id: Ib98275170d063aee38c8fdebc53042fd4d59253e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198968 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Owners-Override: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/main@{#927592}
https://skia.googlesource.com/skia.git/+log/f843d5cf7212..03dd6a47a67b 2021-10-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 5ad5250a3b38 to bb417ace110b (10 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: brianosman@google.com Change-Id: I2182cc3c963fd2ba5662e7b96ab6240fa67aee4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3201618 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927593}
Adds basic support of observable arrays in bind_gen/. This is mostly just a preparation for the coming bind_gen/observable_array.py in a follow-up patch. Bug: 1201744 Change-Id: I874c699f896633f7b4c8cce5e221e3ffd6351372 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198015 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/main@{#927594}
It's new in https://crrev.com/c/2885636 and failing on the bfcache bot. Bug: 1255537 Change-Id: I8b2437b9deeebaaea53b34c767d81860032a2f3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199899 Commit-Queue: Johann Koenig <johannkoenig@google.com> Auto-Submit: Fergal Daly <fergal@chromium.org> Reviewed-by: Yuzu Saijo <yuzus@chromium.org> Cr-Commit-Position: refs/heads/main@{#927595}
Using wpt-import in Chromium 96909a9. With Chromium commits locally applied on WPT: 6e7e392 "[GridNG] Invalidate when alignment changes on OOF elements" 66dbd4c "[WPT] Introduce `RemoteContext.execute_script()` and add basic BFCache tests + helpers" 7ce7e8e "Add .https flag to WebTransport WPT files" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md NOAUTOREVERT=true R=rubber-stamper@appspot.gserviceaccount.com No-Export: true Change-Id: I31d61444d68e1f4e5e8029b146c1691a899fec55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198967 Auto-Submit: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927596}
While the `DevToolsSettings` class has a set of unit tests, we also want at least one integration test that: 1) Fires up the DevTools window 2) Invokes the `registerPreference`/`setPreference` host bindings 3) Verifies that the settings arrived in the correct buckets. R=dsv@chromium.org Bug: 1245541 Change-Id: I29cf2ad43f015343ace19411f3d191ef46bc4bc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3193437 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by: Danil Somsikov <dsv@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/main@{#927597}
This reduce the error count of `cca.py tsc` by 2. Bug: b:172340451 Test: cca.py tsc Change-Id: I0270a7ce5691b31c9469915ba8868fb90636e29b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199900 Reviewed-by: Shik Chen <shik@chromium.org> Commit-Queue: Pi-Hsun Shih <pihsun@chromium.org> Cr-Commit-Position: refs/heads/main@{#927598}
testInitialPositionAndOrientationChange and testToggleFeedEnabled are flaky on ios-simulator-noncq Bug: 1255548 Change-Id: I641d59cbb8f5a2928f724eef63c3d218396045a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198969 Commit-Queue: Johann Koenig <johannkoenig@google.com> Owners-Override: Johann Koenig <johannkoenig@google.com> Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/main@{#927599}
https://skia.googlesource.com/skia.git/+log/03dd6a47a67b..816d9179b3ca 2021-10-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 3de06bcd0c81 to d3764f080f6c (19 revisions) 2021-10-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from b7b7cb76042a to f43b9df4c8a9 (5 revisions) 2021-10-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 3bc0154 to 2d77db4 (493 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: brianosman@google.com Change-Id: I8922b853d8f72289758e5b62be2ec4a06d1ea8c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3201620 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927600}
This reduce the error count of `cca.py tsc` by 1. Bug: b:172340451 Test: cca.py tsc Change-Id: Ia8af2c591aa5e46b34c5d4a3e383fd9a12952703 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3201930 Reviewed-by: Shik Chen <shik@chromium.org> Commit-Queue: Pi-Hsun Shih <pihsun@chromium.org> Cr-Commit-Position: refs/heads/main@{#927601}
This CL removes ScopedDepthTracker from ValidateInlinedUnion(), ValidateContainer(), and ValidateNonInlinedUnion() in order to avoid redundant recursive depth checking. If the validation runs with base::Value type, it increases `stack_depth_` from ValidationContext redundantly. Bug: 1246320 Change-Id: Ifbf400cb7a44ce18310a078a04e4b95799ae4cd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3154109 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/main@{#927602}
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3497a970ea9c..34ad1da7ee6c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC johannkoenig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: johannkoenig@google.com Change-Id: I5279cdd332598560be52d04190946ed43c256dcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3201619 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927603}
Updates base classes of observable array types so that the coming bind_gen/observable_array.py generates the implementation classes inheriting them. Bug: 1201744 Change-Id: I2610eafc7203ddd1a32fb4986a1f69cf50663ad0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199891 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/main@{#927604}
This CL updates the new tab menu item to "New tab" for guest mode instead of "New Incognito tab". Bug: 1254276 Change-Id: I0b4096f6d25c2441ab6997395d0436fb6278bd6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3196373 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/main@{#927605}
Bug: 1255537 Cq-Include-Trybots: luci.chromium.try:android-bfcache-rel,linux-bfcache-rel Change-Id: Ibae1ebc29950797be26b904181c4f2eae4dbffaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3197864 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/main@{#927606}
Roll Chrome Mac PGO profile from chrome-mac-main-1633305549-6e97c3082c3b458085db7c5543aa1c2cc590fd21.profdata to chrome-mac-main-1633326658-c6e2f91cc6a29f2ee84853d3b52f4917f12f480e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I71e438c90e8f64b02f6bf78b0ec6317118ee5aaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200708 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927607}
Roll Chrome Linux PGO profile from chrome-linux-main-1633305549-bab1ddadbe017087cab33e0561216a34a42e5514.profdata to chrome-linux-main-1633326658-6fb420062593bb5549d950d3c8eaba216e7d8abd.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I4c49e68f7e8875eb5acdcceeff60ebcd0718398a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3202011 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927608}
Roll Chrome Win64 PGO profile from chrome-win64-main-1633313891-048cc93a982a2256fc2374370d70dfd7d2e603c7.profdata to chrome-win64-main-1633326658-9ae04a632e53039183dad2ea6cec9d9561dca6aa.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ieaccdbf60cb1f35f0fd0afa633e90b206328f13a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200706 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927609}
Roll Chrome Win32 PGO profile from chrome-win32-main-1633313891-dc76ccf42e8816f3c6809b396d551b1ed90c8357.profdata to chrome-win32-main-1633326658-55d32c1dc4129ef3dac0b08bc444c35f5ef5e95c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I188792300138c7fd359acff61b7f22327787a588 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200707 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927610}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )