Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lutris: remove proton support from lutris #3330

Closed
wants to merge 1 commit into from

Conversation

GloriousEggroll
Copy link
Contributor

Reasons for doing this:

  1. As of Proton 5.13, Proton uses a new runtime which runs in its own container.
    Due to this, it is no longer viable or recommended to run proton outside of steam.

  2. Additionally, neither the old Proton versions nor the new versions properly
    generate the wine prefix in the standard way because they do not ship with wineboot.
    So if someone removes their prefix then runs a game with proton, it will not properly
    correct a new prefix.

  3. Lastly, the proton script uses specific environment variables which are not in place
    when running proton directly by the wine executable within it, such as the
    steam game ID, gstreamer variables, wine username, and others which are important to the
    Proton-specific environment.

  4. Since lutris does not run proton games using the lutris script, as mentioned it does not use important environment variables. Not specifying the steam game ID can lead to game-specific fixes not working. Proton also requires a custom patch and WINEUSERNAME defined alongside the patch in order to save to any user other than 'steamuser'. And lastly, it needs the gstreamer library envvar defined so that mfplat games can play. I have submitted other PRs for the gstreamer stuff to work in lutris already.

Reasons for doing this:

1. As of Proton 5.13, Proton uses a new runtime which runs in its own container.
Due to this, it is no longer viable or recommended to run proton outside of steam.

2. Additionally, neither the old Proton versions nor the new versions properly
generate the wine prefix in the standard way because they do not ship with wineboot.
So if someone removes their prefix then runs a game with proton, it will not properly
correct a new prefix.

3. Lastly, the proton script uses specific environment variables which are not in place
when running proton directly by the wine executable within it, such as the
steam game ID, gstreamer variables, wine username, and others which are important to the
Proton-specific environment.
@Arcitec
Copy link

Arcitec commented Dec 23, 2021

@strycore Hi, I'm curious... why was this closed without comment?

I see that the latest Lutris still has Proton runtime.

GloriousEggroll is one of the biggest experts on Proton in the world. I would trust his word on this.

@strycore
Copy link
Member

I trust GE too but Lutris isn't currently able to use Proton in a reliable manner since it has switched to Pressure Vessel.

Once we support Pressure Vessel in Lutris, we'll be able to add support for Proton builds.

Meanwhile, GE also makes some Wine builds that can be used with Lutris: https://github.com/GloriousEggroll/wine-ge-custom/releases

@Arcitec
Copy link

Arcitec commented Dec 23, 2021

@strycore Okay I see, thanks for the information! If I understand right, pressure-vessel is Proton's own sub-sandboxing for games. I heard about troubles with this. Gotcha. :)

@strycore
Copy link
Member

Yes, and were still using something that is very similar to the old Steam runtime, which was used with earlier versions of Proton

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants