Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.29.1 is gone #330

Closed
joerg-krause opened this issue Jun 1, 2019 · 8 comments · Fixed by #332
Closed

Version 1.29.1 is gone #330

joerg-krause opened this issue Jun 1, 2019 · 8 comments · Fixed by #332

Comments

@joerg-krause
Copy link
Contributor

Some hours ago I've update the luv package in Buildroot to version 1.29.1-1. Unfortunately, this version is gone now 😢

@zhaozg
Copy link
Member

zhaozg commented Jun 1, 2019

Sorry, I do something for #329, you can find it https://github.com/zhaozg/luv/tree/exloop

@joerg-krause
Copy link
Contributor Author

Yes, but deleting commits and tags from the public master branch is bad as this breaks package managers.

@SinisterRectus
Copy link
Member

I've seen the recent changes, including the force pushes, come across our Discord webhook. I'm not too invested in any of the luv code, and I don't want to sound rude here, but I think that in the future, it would be good to allow more time for people to review significant changes before version bumps.

@zhaozg
Copy link
Member

zhaozg commented Jun 1, 2019

Really sorry, @luvit team not active enough, I am too anxious to release some new features.
I'm be sure to stop causing similar events to happen next time.

Say again sorry.

@joerg-krause
Copy link
Contributor Author

@zhaozg Maybe you can just update libuv to 1.29.1 (like in zhaozg@946ad2f) for now and add the new features later?

@zhaozg
Copy link
Member

zhaozg commented Jun 2, 2019

@joerg-krause you mean tag 1.29.1

@zhaozg zhaozg reopened this Jun 2, 2019
@squeek502
Copy link
Member

@zhaozg we should probably release 1.29.1-2 instead, since Luarocks still has 1.29.1-1 which is now broken, and since you re-released 1.29.1-0 I'm not sure what happens to that on Luarocks.

@joerg-krause
Copy link
Contributor Author

Releasing a 1.29.1-2 would be the best. However, I've updated the hash sum for the source tarball in Buildroot for the re-released and re-uploaded version 1.29.1-1.

buildroot-auto-update pushed a commit to buildroot/buildroot that referenced this issue Jun 4, 2019
Upstream removed (using git force-push) and recreated version 1.29.1-1
and re-uploaded the source tarball. Therefore, the hash has changed and
needs to be updated.

See:
luvit/luv#330

Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants