socktype isn't important for a DNS result

[imzyxwvu]

DNS servers doesn't return the address's socktype so registering this field can be removed from on_addrinfo.

Does anyone think so?

[creationix]

Not sure I understand.

[imzyxwvu]

In the dns.c:on_addrinfo, remove these code:

      if (ntohs(port)) {
        lua_pushinteger(L, ntohs(port));
        lua_setfield(L, -2, "port");
      }
      if (curr->ai_socktype == SOCK_STREAM) {
        lua_pushstring(L, "STREAM");
        lua_setfield(L, -2, "socktype");
      }
      else if (curr->ai_socktype == SOCK_DGRAM) {
        lua_pushstring(L, "DGRAM");
        lua_setfield(L, -2, "socktype");
      }
      switch (curr->ai_protocol) {
...
        default:
          lua_pushstring(L, NULL);
      }
      lua_setfield(L, -2, "protocol");

Because this is just the arg for querying and DNS servers doesn't return this at all. DNS server just record the IP address but it doesn't care which port and socket type the client will use. It is defined in addrinfo struct but not used by getaddrinfo. And if you use DNS the protocol must be INET or INET6 because DNS belongs to IP but INET or INET6 can be determined with the family field.

So these code will cause misunderstanding.

By the way, I think libuv has just one API for name resolving, so it is not necessary to create a sperated dns.c file.

[creationix]

@imzyxwvu Please review the PR to make sure I understand what you mean.

I know there is only one dns function in libuv, but I put it in it's own file because it's a lot of code. Even after this patch is applied it's over 200 lines while parts like pipe are well under 100 lines.

[imzyxwvu]

I still thought some fields are used for C socket API and useless for Lua. But in some cases those may be required, so this should be discussed in the future.