Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix uv.shutdown cb being called when canceled #414

Closed
wants to merge 1 commit into from
Closed

Fix uv.shutdown cb being called when canceled #414

wants to merge 1 commit into from

Commits on Oct 14, 2019

  1. Fix uv.shutdown cb being called when canceled 

    This could happen after lua_close, and after absolutely all handles have been closed/freed, so there's no point in running the callback.

There might be other legitimate situations where UV_ECANCELED should be passed along to the callback. If so, then there would need to be a more involved fix here to handle when the stream is closed via lua_close/__gc
    @squeek502
    squeek502 committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    485a7ef View commit details
    Browse the repository at this point in the history