Skip to content

Configure XLink chunk size #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 24, 2021
Merged

Configure XLink chunk size #346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
48a76eb
Pipeline: add setXlinkChunkSize
alex-luxonis Aug 17, 2021
7de407b
Fix naming `setXlinkChunkSize` -> `setXLinkChunkSize`
alex-luxonis Aug 18, 2021
e44938b
DeviceBindings: add `{set/get}XLinkChunkSize` RPC calls
alex-luxonis Aug 23, 2021
8b80c99
Add some missing Device() constructor overloads - no-pipeline versions
alex-luxonis Aug 23, 2021
9faa1d5
Device(): rename param for consistency: `deviceDesc` -> `devInfo`
alex-luxonis Aug 23, 2021
23fb52a
Remove for now docstrings for some Device() constructors,
alex-luxonis Aug 24, 2021
dd6f40d
Add back docstrings pointing to DeviceBase
alex-luxonis Aug 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion depthai-core
Open in desktop
Submodule depthai-core updated 6 files
+1 −1 cmake/Depthai/DepthaiDeviceSideConfig.cmake
+16 −0 include/depthai/device/DeviceBase.hpp
+10 −0 include/depthai/pipeline/Pipeline.hpp
+1 −1 shared/depthai-shared
+12 −0 src/device/DeviceBase.cpp
+4 −0 src/pipeline/Pipeline.cpp
27 changes: 25 additions & 2 deletions src/DeviceBindings.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,12 +155,12 @@ void DeviceBindings::bind(pybind11::module& m, void* pCallstack){
// Non blocking constructor
py::gil_scoped_release release;
return std::make_unique<DeviceBase>(version, deviceInfo, usb2Mode);
}), py::arg("version"), py::arg("deviceDesc"), py::arg("usb2Mode") = false, DOC(dai, DeviceBase, DeviceBase, 15))
}), py::arg("version"), py::arg("devInfo"), py::arg("usb2Mode") = false, DOC(dai, DeviceBase, DeviceBase, 15))
.def(py::init([](OpenVINO::Version version, const DeviceInfo& deviceInfo, std::string pathToCmd){
// Non blocking constructor
py::gil_scoped_release release;
return std::make_unique<DeviceBase>(version, deviceInfo, pathToCmd);
}), py::arg("version"), py::arg("deviceDesc"), py::arg("pathToCmd"), DOC(dai, DeviceBase, DeviceBase, 16))
}), py::arg("version"), py::arg("devInfo"), py::arg("pathToCmd"), DOC(dai, DeviceBase, DeviceBase, 16))

.def("isPipelineRunning", [](DeviceBase& d) { py::gil_scoped_release release; return d.isPipelineRunning(); }, DOC(dai, DeviceBase, isPipelineRunning))
.def("startPipeline", [](DeviceBase& d){
Expand Down Expand Up @@ -198,6 +198,8 @@ void DeviceBindings::bind(pybind11::module& m, void* pCallstack){
.def("getMxId", [](DeviceBase& d) { py::gil_scoped_release release; return d.getMxId(); }, DOC(dai, DeviceBase, getMxId))
.def("readCalibration", [](DeviceBase& d) { py::gil_scoped_release release; return d.readCalibration(); }, DOC(dai, DeviceBase, readCalibration))
.def("flashCalibration", [](DeviceBase& d, CalibrationHandler calibrationDataHandler) { py::gil_scoped_release release; return d.flashCalibration(calibrationDataHandler); }, py::arg("calibrationDataHandler"), DOC(dai, DeviceBase, flashCalibration))
.def("setXLinkChunkSize", [](DeviceBase& d, int s) { py::gil_scoped_release release; d.setXLinkChunkSize(s); }, py::arg("sizeBytes"), DOC(dai, DeviceBase, setXLinkChunkSize))
.def("getXLinkChunkSize", [](DeviceBase& d) { py::gil_scoped_release release; return d.getXLinkChunkSize(); }, DOC(dai, DeviceBase, getXLinkChunkSize))
;


Expand All @@ -222,6 +224,27 @@ void DeviceBindings::bind(pybind11::module& m, void* pCallstack){
return std::make_unique<Device>(pipeline, deviceInfo, pathToCmd);
}), py::arg("pipeline"), py::arg("devInfo"), py::arg("pathToCmd"), DOC(dai, Device, Device, 7))

// Device constructor - OpenVINO version
.def(py::init([](OpenVINO::Version version){ return deviceConstructorHelper<Device>(version); }), py::arg("version") = Pipeline::DEFAULT_OPENVINO_VERSION, DOC(dai, DeviceBase, DeviceBase, 10))
.def(py::init([](OpenVINO::Version version, bool usb2Mode){
// Blocking constructor
return deviceConstructorHelper<Device>(version, std::string(""), usb2Mode);
}), py::arg("version"), py::arg("usb2Mode"), DOC(dai, DeviceBase, DeviceBase, 11))
.def(py::init([](OpenVINO::Version version, const std::string& pathToCmd){
// Blocking constructor
return deviceConstructorHelper<Device>(version, pathToCmd);
}), py::arg("version"), py::arg("pathToCmd"), DOC(dai, DeviceBase, DeviceBase, 12))
.def(py::init([](OpenVINO::Version version, const DeviceInfo& deviceInfo, bool usb2Mode){
// Non blocking constructor
py::gil_scoped_release release;
return std::make_unique<Device>(version, deviceInfo, usb2Mode);
}), py::arg("version"), py::arg("devInfo"), py::arg("usb2Mode") = false, DOC(dai, DeviceBase, DeviceBase, 15))
.def(py::init([](OpenVINO::Version version, const DeviceInfo& deviceInfo, std::string pathToCmd){
// Non blocking constructor
py::gil_scoped_release release;
return std::make_unique<Device>(version, deviceInfo, pathToCmd);
}), py::arg("version"), py::arg("devInfo"), py::arg("pathToCmd"), DOC(dai, DeviceBase, DeviceBase, 16))

.def("getOutputQueue", static_cast<std::shared_ptr<DataOutputQueue>(Device::*)(const std::string&)>(&Device::getOutputQueue), py::arg("name"), DOC(dai, Device, getOutputQueue))
.def("getOutputQueue", static_cast<std::shared_ptr<DataOutputQueue>(Device::*)(const std::string&, unsigned int, bool)>(&Device::getOutputQueue), py::arg("name"), py::arg("maxSize"), py::arg("blocking") = true, DOC(dai, Device, getOutputQueue, 2))
.def("getOutputQueueNames", &Device::getOutputQueueNames, DOC(dai, Device, getOutputQueueNames))
Expand Down
2 changes: 2 additions & 0 deletions src/pipeline/PipelineBindings.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ void PipelineBindings::bind(pybind11::module& m, void* pCallstack){
.def_readwrite("pipelineVersion", &GlobalProperties::pipelineVersion)
.def_readwrite("cameraTuningBlobSize", &GlobalProperties::cameraTuningBlobSize, DOC(dai, GlobalProperties, cameraTuningBlobSize))
.def_readwrite("cameraTuningBlobUri", &GlobalProperties::cameraTuningBlobUri, DOC(dai, GlobalProperties, cameraTuningBlobUri))
.def_readwrite("xlinkChunkSize", &GlobalProperties::xlinkChunkSize, DOC(dai, GlobalProperties, xlinkChunkSize))
;

// bind pipeline
Expand All @@ -95,6 +96,7 @@ void PipelineBindings::bind(pybind11::module& m, void* pCallstack){
.def("setOpenVINOVersion", &Pipeline::setOpenVINOVersion, py::arg("version") = Pipeline::DEFAULT_OPENVINO_VERSION, DOC(dai, Pipeline, setOpenVINOVersion))
.def("getOpenVINOVersion", &Pipeline::getOpenVINOVersion, DOC(dai, Pipeline, getOpenVINOVersion))
.def("setCameraTuningBlobPath", &Pipeline::setCameraTuningBlobPath, py::arg("path"), DOC(dai, Pipeline, setCameraTuningBlobPath))
.def("setXLinkChunkSize", &Pipeline::setXLinkChunkSize, py::arg("sizeBytes"), DOC(dai, Pipeline, setXLinkChunkSize))
.def("setCalibrationData", &Pipeline::setCalibrationData, py::arg("calibrationDataHandler"), DOC(dai, Pipeline, setCalibrationData))
.def("getCalibrationData", &Pipeline::getCalibrationData, DOC(dai, Pipeline, getCalibrationData))
// 'Template' create function
Expand Down