-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: adding k8s probes #2687
api: adding k8s probes #2687
Conversation
Hey @fran2344 thanks for the contribution! I think what I'm going to ask you to do is break up this PR into 3 different parts so the diff's are smaller and easier to review. Lets do an individual PR for, 1) The Proto changes, 2) the backend, 3) the frontend. Breaking it up will be easier for the team to review and will be able to get the changes in faster. |
Hi @mikecutalo I update and remove the references in backend and frontend please let me know if its ok |
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | golang | stage | minor | `1.19.5-buster` -> `1.20.5-buster` | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/lyft/clutch). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMTAuMCIsInVwZGF0ZWRJblZlciI6IjM1LjExMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
483a5af
to
0162fc7
Compare
Description
Adding a new feature that update Liveness Probes and Readness probes in k8s cluster deployments.
Updating attributes in deployment
Response if everything goes well
Testing Performed
You could try with the frontend or pointing directly to the backend