Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mingw64 vvc: GCC 13.1 requires '#include <cstdint>' in TypeDef.h #2436

Closed
LigH-de opened this issue May 14, 2023 · 7 comments
Closed

mingw64 vvc: GCC 13.1 requires '#include <cstdint>' in TypeDef.h #2436

LigH-de opened this issue May 14, 2023 · 7 comments

Comments

@LigH-de
Copy link
Contributor

LigH-de commented May 14, 2023

As reported in VVCSoftware_VTM issue 2

In file included from G:/MABS/build/vvc-git/source/Lib/CommonLib/CommonDef.h:65,
                 from G:/MABS/build/vvc-git/source/Lib/CommonLib/AdaptiveLoopFilter.h:41,
                 from G:/MABS/build/vvc-git/source/Lib/CommonLib/AdaptiveLoopFilter.cpp:38:
G:/MABS/build/vvc-git/source/Lib/CommonLib/TypeDef.h:253:15: error: 'int16_t' does not name a type
  253 | typedef       int16_t           Pel;               ///< pixel type
      |               ^~~~~~~
G:/MABS/build/vvc-git/source/Lib/CommonLib/TypeDef.h:54:1: note: 'int16_t' is defined in header '<cstdint>'; did you forget to '#include <cstdint>'?
   53 | #include "CommonDef.h"
  +++ |+#include <cstdint>
   54 | 
G:/MABS/build/vvc-git/source/Lib/CommonLib/TypeDef.h:255:15: error: 'int16_t' does not name a type
  255 | typedef       int16_t           TMatrixCoeff;      ///< transform matrix coefficient
      |               ^~~~~~~
G:/MABS/build/vvc-git/source/Lib/CommonLib/TypeDef.h:255:15: note: 'int16_t' is defined in header '<cstdint>'; did you forget to '#include <cstdint>'?
G:/MABS/build/vvc-git/source/Lib/CommonLib/TypeDef.h:256:15: error: 'int16_t' does not name a type
  256 | typedef       int16_t           TFilterCoeff;      ///< filter coefficient
      |               ^~~~~~~
G:/MABS/build/vvc-git/source/Lib/CommonLib/TypeDef.h:256:15: note: 'int16_t' is defined in header '<cstdint>'; did you forget to '#include <cstdint>'?
{...}
@LigH-de
Copy link
Contributor Author

LigH-de commented May 16, 2023

In the meantime... build/vvc_extra.sh

_pre_ninja() {
    sed -i 's!#include <cstdlib>!#include <cstdlib>\n#include <cstdint>!' ${REPO_DIR}/source/Lib/CommonLib/CommonDef.h
    sed -i 's!#include <cstddef>!#include <cstddef>\n#include <cstdint>!' ${REPO_DIR}/source/Lib/CommonLib/TypeDef.h
    sed -i 's!#include <cstdarg>!#include <cstdarg>\n#include <cstdint>!' ${REPO_DIR}/source/Lib/CommonLib/dtrace.h
    sed -i 's!#include <vector>!#include <cstdint>\n#include <vector>!' ${REPO_DIR}/source/Lib/CommonLib/Hash.h
    sed -i 's!#include <vector>!#include <cstdint>\n#include <vector>!' ${REPO_DIR}/source/Lib/Utilities/program_options_lite.h
}

@hydra3333
Copy link
Contributor

thank you

@LigH-de
Copy link
Contributor Author

LigH-de commented May 18, 2023

Nobody reminded me that the repo above is a local fork for the m-ab-s project...

Reported to Fraunhofer VVC trac, ticket 1600.

@LigH-de
Copy link
Contributor Author

LigH-de commented May 26, 2023

1 week without any reaction upstream. Is this project abandoned?

@1480c1
Copy link
Member

1480c1 commented May 26, 2023 via email

@LigH-de
Copy link
Contributor Author

LigH-de commented May 26, 2023

No, I mean Fraunhofer VVC VTM. New "blocker" grade ticket should either be taken serious or degraded.

OK, got a reply there.

@LigH-de
Copy link
Contributor Author

LigH-de commented Jun 6, 2023

A fix has been committed. Works again.

@LigH-de LigH-de closed this as completed Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants