Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove urllib3 and pyopenssl direct dependency #43

Merged
merged 3 commits into from
May 22, 2023
Merged

Remove urllib3 and pyopenssl direct dependency #43

merged 3 commits into from
May 22, 2023

Conversation

yonting
Copy link
Contributor

@yonting yonting commented May 17, 2023 •
edited
Loading

Addresses issue #40

yonting
yonting commented May 17, 2023
View reviewed changes
requests_pkcs12.py

try:
from ssl import PROTOCOL_TLS as default_ssl_protocol
from ssl import PROTOCOL_TLS_CLIENT as default_ssl_protocol
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes another deprecation warning as in ssl docs.

@vog vog merged commit ecf65b1 into m-click:master May 22, 2023
@vog
Copy link
Member

vog commented May 22, 2023

Thanks for your contribution! We just released version 1.16 which contains this improvement:

https://pypi.org/project/requests-pkcs12/

@vog vog mentioned this pull request May 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yonting @vog