Skip to content

Conversation

stephen-soltesz
Copy link
Contributor

@stephen-soltesz stephen-soltesz commented Aug 12, 2020

This change restores dual stack support to the access envelope.

As long as clients try available IPs for a hostname, then the same protocol used to open the envelope will be available to connect to the service.


This change is Reviewable

@coveralls
Copy link

coveralls commented Aug 12, 2020

Pull Request Test Coverage Report for Build 121

  • 39 of 39 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 99.664%

Totals Coverage Status
Change from base Build 113: 0.2%
Covered Lines: 594
Relevant Lines: 596

💛 - Coveralls

Copy link

@gfr10598 gfr10598 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 7 of 7 files at r1, 1 of 1 files at r2.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @gfr10598)

@stephen-soltesz stephen-soltesz merged commit e41b3d1 into master Aug 12, 2020
@stephen-soltesz stephen-soltesz deleted the sandbox-soltesz-dualstack branch August 12, 2020 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants