Add support for integration with CloudBuild #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pboothe
approved these changes
Dec 19, 2019
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! 1 of 1 approvals obtained (waiting on @pboothe)
pboothe
approved these changes
Dec 19, 2019
There was a problem hiding this comment.
Reviewable status:
|
Please add two issues: one to call for building a generic "only run jobs on the following projects" entrypoint to gcp-config, and another to switch away from substring searching and to move to exact string matching in a string array. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a basic Dockerfile and Cloud Build configuration for applying the stctl configuration to our common projects.
To support using a single cloud build file across multiple projects, this change also includes a new flag to stctl that makes execution conditional on the specified -allowed-projects -- if the command runs in another project, then it will exit cleanly without applying the config.
After merging this change, we will need to setup the Cloud Build triggers in each project.
This change is