Skip to content

Conversation

robertodauria
Copy link
Contributor

@robertodauria robertodauria commented May 24, 2021

This PR replaces a defer w.Close() adding explicit error checking.

The documentation of Close() states that an object becomes available on GCS only after Close() has been successfully called.
Particularly, permission errors are only reported when closing the writer.

This change is Reviewable

@coveralls
Copy link
Collaborator

coveralls commented May 24, 2021

Pull Request Test Coverage Report for Build 1023

  • 12 of 12 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 93.533%

Totals Coverage Status
Change from base Build 1016: 0.02%
Covered Lines: 1909
Relevant Lines: 2041

💛 - Coveralls

Copy link
Contributor

@stephen-soltesz stephen-soltesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1.
Reviewable status: 0 of 1 LGTMs obtained

@robertodauria robertodauria merged commit 5e81613 into master May 24, 2021
@robertodauria robertodauria deleted the sandbox-roberto-fix-upload-close branch May 24, 2021 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants