-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate site deployment to Firebase #9
Conversation
…sifex for testing, added firebase deployment files & associated travis config.
…ages from transifex
…ng linked node modules
…that doesn't require copies of node_modules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once comment on the .travis.yml
file, and a general question about whether we should be including any "lock" and "cache" files in the repo. For example, the yarn.lock
file says it is autogenerated (and it's very large). Is this a file that needs to be in version control?
Reviewed 39 of 43 files at r1.
Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @critzo and @nkinkade)
.travis.yml, line 17 at r1 (raw file):
on: repo: m-lab/mlab-speedtest all_branches: true
I think all_branches
can be removed, since we are dealing with tag here, not a branch.
yarn.lock, line 1 at r1 (raw file):
# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.
Should this auto-generated files be included in version control?
I'll have to test without the yarn file in the repo. I think we can get away with dropping it but will check. It's only there to get around some issues with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is yarn.lock
generated? Is package-lock.json
generated too?
Reviewed 1 of 3 files at r2.
Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @critzo)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @critzo)
.travis.yml, line 17 at r1 (raw file):
Previously, nkinkade wrote…
I think
all_branches
can be removed, since we are dealing with tag here, not a branch.
condition
can be removed too.
@nkinkade The app is dated enough that it is using I would recommend that we get this app hosting migrated and deal with refactoring it later. Is that ok? Realistically, we need to use something like webpack and that will take more time. |
.travis.yml, line 17 at r1 (raw file): Previously, nkinkade wrote…
removed in most recent commit. |
yarn.lock, line 1 at r1 (raw file): Previously, nkinkade wrote…
This file does need to be in version control |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@critzo: Thanks for looking into all these. LGTM!
Reviewed 2 of 43 files at r1, 1 of 1 files at r3.
Reviewable status: complete! 1 of 1 approvals obtained (waiting on @nkinkade)
This PR replaces the Travis deployment to AWS with deployment to Google Firebase. Only the production site is added to this PR in the in the interest of moving off AWS completely. All changes in this PR can be previewed here: https://mlab-speedtest.firebaseapp.com
All currently completed translations from Transifex are also added with this PR. Supported languages other than English will now include:
@nkinkade PTAL?
This change is