feat(cmd/ndt7-client): support gathering profile info #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Useful to investigate m-lab#59.
robertodauria
requested changes
Jun 3, 2021
There was a problem hiding this comment.
Just a few little things, then 
Reviewed 4 of 4 files at r1.
Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @bassosimone)
cmd/ndt7-client/main.go, line 41 at r1 (raw file):
// download. // // The `-cpuprofile` flag defines the file where to write a CPU profile
s/cpuprofile/profile/
cmd/ndt7-client/main.go, line 120 at r1 (raw file):
var ( flagProfile = flag.String("profile", "", "file where to store cpuprofile (see https://blog.golang.org/pprof)")
s/cpuprofile/pprof profile/
cmd/ndt7-client/main.go, line 284 at r1 (raw file):
flag.Parse() if *flagProfile != "" {
Could we add a warning that enabling the profiler may impact performance?
bassosimone
commented
Jun 7, 2021
bassosimone
commented
Jun 7, 2021
robertodauria
approved these changes
Jun 7, 2021
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 1 approvals obtained (waiting on @bassosimone)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful to investigate #59.
This change is