download: discard binary messages #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the download test to avoid allocating memory for incoming binary messages during the download test, by moving from
conn.ReadMessage()toconn.NextReader()and redirecting the output toioutil.Discard.This allows for a significant reduction in CPU utilization (~25% according to pprof) and consequently improves performance on resource-constrained hardware (such as embedded ARM devices - Raspberry Pi, ODROID, etc.)
Tested on an ARMv7 ODROID device and further confirmed to improve performance on an ARMv8 (arm64) Raspberry Pi at #59.
This change is