This repository was archived by the owner on Oct 5, 2022. It is now read-only.
Add basic script to convert sites.py to jsonnet site files. #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nkinkade FYI |
pboothe
suggested changes
Apr 8, 2019
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 1 LGTMs obtained (waiting on @pboothe and @stephen-soltesz)
plsync/convert_test.py, line 10 at r1 (raw file):
import unittest class ConvertTest(unittest.TestCase):
Please add a test for a v6-enabled site as well.
stephen-soltesz
commented
Apr 8, 2019
There was a problem hiding this comment.
Reviewable status: 0 of 1 LGTMs obtained (and 1 stale) (waiting on @pboothe)
plsync/convert_test.py, line 10 at r1 (raw file):
Previously, pboothe (Peter Boothe) wrote…
Please add a test for a v6-enabled site as well.
Done.
pboothe
approved these changes
Apr 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a way to convert all current M-Lab sites.
One new feature is that we lookup the site ASN to physical sites using ipinfo and add that as an annotation.
Note, this script is only intended to be used approximately once.
This change is