This repository was archived by the owner on Oct 5, 2022. It is now read-only.
Removes --physical option from legacyconfig.py calls #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at options doesn't exist in legacyconfig.py.
stephen-soltesz
approved these changes
Jun 20, 2019
There was a problem hiding this comment.
Sorry about that.
Reviewed 1 of 1 files at r1.
Reviewable status: 0 of 1 LGTMs obtained
stephen-soltesz
approved these changes
Jun 20, 2019
complete! 1 of 1 LGTMs obtained
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds
set -euxo pipefailto generate_prometheus_targets.sh to cause it to fail on errors. Previously, this script could fail and Travis would never notice.This change is