This repository was archived by the owner on Oct 5, 2022. It is now read-only.
Limits Prom target generation to only legacy/scraper targets #291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eus_targets.sh to avoid confusion with the new generate_prometheus_targets.sh script in m-lab/prometheus-support.
…cy' to avoid confusion with the deploy_prometheus_targets.sh script in the m-lab/prometheus-support repo.
… now generated in the prometheus-support repo.
stephen-soltesz
approved these changes
Jul 19, 2019
There was a problem hiding this comment.
Can we call it *_scraper_prometheus_targets.sh? That may be more helpful than 'legacy' for knowing when it's needed or not any more.
Reviewable status:
complete! 1 of 1 LGTMs obtained (waiting on @stephen-soltesz)
…per' instead of 'legacy' to be more clear.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of an effort to remove all platform cluster dependencies on this legacy repo. With the PR, this repo will only generate and deploy legacy/scraper Prometheus targets. All other Prometheus targets generation and deployment is being moved to the prometheus-support repo.
I renamed the generation and deployment scripts to include the word "legacy" so as not to confuse them with the ones in the prometheus-support repo.
This change is